-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: everything created as root and honors PUID, PGID and UMASK environment variables #206
Fix: everything created as root and honors PUID, PGID and UMASK environment variables #206
Conversation
@DorianMazur Thanks for submitting the PR. Have you tried these changes on your local machine? I am suspecting that linuxserver/baseimage-alpine might not have Python3 installed. |
@mandarons I've successfully built it locally, but you may be right. I will update this PR with a more suitable image. |
I modified Dockerfile and it's working now:
Files are created as PUID/PGID:
|
@mandarons I also moved |
Here are also plain logs:
|
@DorianMazur Is the new image working for you? It is not working for me. Throwing below error when I run the container:
I am looking into it... |
I tried building the merged mandarons:main from DorianMazur:fix/everything_created_as_root and I get this error: **** Permissions could not be set. This is probably because your volume mounts are remote or read-only. **** | | | | | | | | Based on images from linuxserver.io To support LSIO projects visit: ─────────────────────────────────────── User UID: 100 find: unrecognized: -xtype Usage: find [-HL] [PATH]... [OPTIONS] [ACTIONS] Search for files and perform actions on them.
Actions: This is my config.yaml app: Drive destinationdestination: "/app/icloud/" |
@Sev7nrayne yeah, same as mine. I will look into it. |
Ever since this was merged in, when I have PUID PGUID as environment variables defined while running in UNRAID it fails and restarts. I can not capture logs since it is restarted but I figured I would let you know. I was using 99/100 but I reverted to not using any as a workaround. |
Thanks. Not sure what's so unique about Unraid as I don't have it set up to figure out. BTW, it is usually recommended to use values higher than 1000 for PUID and PGID to avoid any conflicts. |
I've had issues with 1.18.1 and newer, reverting back to 1.18.0 works perfectly for me on unRAID. I also tried changing the PUID and PGID which did prevent the crashing but instead it could never find the password in the keyring, even after running the icloud command to login again... not really sure why though. |
Same. Reverted to older version.
@mandarons, I can provide you with access to clean Unraid setup if needed |
same here with unraid. @Verkhovskyi @miafoo did you find a solution with the current version? |
Unfortunately no, but 1.18.0 has been rock stable for me so will probably not bother attempting upgrading for a few months. |
Sorry folks, for messing this one. I thought that docker works the same in all environments. Clearly, that's not the case. There must be something wrong with my PUID, PGID implementation for UNRAID.
@Verkhovskyi : that would be great. I never used UNRAID before. Meanwhile, I will start digging through how UNRAID uses Docker to see if there is any conflict with my implementation. |
@nicx, no, using 1.16.1 for now @mandarons, I'll set it up and DM you credentials on reddit (or anywhere else if you wish). Most likely tomorrow or the day after. Will access through Wireguard be ok? |
@Verkhovskyi : Thank you for the offer. Someone recently sponsored to help me purchase an Unraid license. I will be using it to resolve this issue. |
I replaced the image. Image from linuxserver is better and supports PGID/PUID out of the box.
Fixes #205 #140