fix(core): fix changelog configuration (nrwl#20138)

mandarini · Nov 8, 2023 · b4faf2d · b4faf2d
1 parent 80ec78a
commit b4faf2d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/nx.json b/nx.json
@@ -26,6 +26,13 @@
     ]
   },
   "release": {
+    "releaseTagPattern": "{version}",
+    "changelog": {
+      "workspaceChangelog": {
+        "createRelease": "github",
+        "file": false
+      }
+    },
     "groups": {
       "npm": {
         "projects": [

diff --git a/packages/nx/src/command-line/release/utils/git.ts b/packages/nx/src/command-line/release/utils/git.ts
@@ -191,9 +191,9 @@ export function parseGitCommit(commit: RawGitCommit): GitCommit | null {
   };
 }
 
-export function getCommitHash(ref: string) {
+export async function getCommitHash(ref: string) {
   try {
-    return execCommand('git', ['rev-parse', ref]);
+    return (await execCommand('git', ['rev-parse', ref])).trim();
   } catch (e) {
     throw new Error(`Unknown revision: ${ref}`);
   }

diff --git a/scripts/nx-release.ts b/scripts/nx-release.ts
@@ -84,7 +84,7 @@ const LARGE_BUFFER = 1024 * 1000000;
       maxBuffer: LARGE_BUFFER,
     });
 
-    let changelogCommand = `pnpm nx release changelog ${options.version} --tagVersionPrefix="" --file false --create-release github --interactive`;
+    let changelogCommand = `pnpm nx release changelog ${options.version} --interactive workspace`;
     if (options.from) {
       changelogCommand += ` --from ${options.from}`;
     }