Add EIP1559 support for eth_maxPriorityFeePerGas and eth_feeHistory #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akramhussein
changed the title
InoMurko
approved these changes
May 9, 2022
|
I took a look at the failing tests and it looks like the CircleCI job is using Parity/OpenEthereum. During the London Fork, Parity/OpenEthereum was deprecated and does not support London/EIP1559. |
|
Tests are also wrong on the |
Done |
ayrat555
approved these changes
May 10, 2022
|
@akramhussein thank you for your contribution. your changes were released in 0.10.0. I skipped your tests for now. we need to improve our ci I remember @rupurt was working on this in #106. so how it's going? 😄 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
eth_maxPriorityFeePerGasandeth_feeHistorywhich were added during the London fork for EIP1559 support.Reference