heathzenith/h89.cpp: Reduce duplicate BIOS declarations #12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rb6502
reviewed
Nov 2, 2024
| @@ -1040,122 +1040,133 @@ void h89_mms_state::h89_mms(machine_config &config) | |||
| m_intr_socket->set_fixed(true); | |||
| } | |||
|
|
|||
| #define ROM_H17 \ | |||
There was a problem hiding this comment.
This could be simplified down a bit. Only h88 has the H88 monitor so it doesn't need to be macro-ized, and the h89 variants have a common set of options (Z17, Ultimeth, etc) that could all be one macro.
There was a problem hiding this comment.
I can undo the H88 one. But for the h89 and h89_sigmasoft, once the left bus is fully implemented, we will be able to remove the h89_sigmasoft system and then all systems would have a unique set of roms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the BIOS definitions DRY.
I have several more BIOSes to add. This should make it clearer on followup PRs.