Test activate on windows

[jtpio]

Attempt at fixing #4.

[dhirschfeld]

I think conda init powershell only initialises the old powershell (v5) and not he new pwsh. Worth a try at least.

See also: #4 (comment)

[jtpio]

Thanks @dhirschfeld!

[dhirschfeld]

That's good news - it passed the first step. Now we just need to fix the others...

[dhirschfeld]

Suggested change

	run: conda activate base && mamba install -y -c conda-forge xtensor
	shell: powershell
	run: |
	conda activate base
	mamba install -y -c conda-forge xtensor

[dhirschfeld]

Suggested change

	run: mamba install -y -c conda-forge notebook ipywidgets
	shell: powershell
	run: |
	conda activate base
	mamba install -y -c conda-forge notebook ipywidgets

[jtpio]

That's good news - it passed the first step. Now we just need to fix the others...

But don't we want to have this in the action itself? So the users of the action don't need to explicitly activate the environment?

[dhirschfeld]

Suggested change

	run: mamba list
	shell: powershell
	run: |
	conda activate base
	mamba list

[dhirschfeld]

I'm not entirely sure the repeated activation is necessary but I figure it's easiest to get something working then take out what isn't needed.

[dhirschfeld]

I think conda init should automatically activate the base env so they won't be necessary but if it turns out they are you can set a config to do it automatically:

conda config --set auto_activate_base true

[dhirschfeld]

Also, to not have to set shell: powershell on every step you could set a default (IIUC):
https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrun

[jtpio]

I think conda init should automatically activate the base env so they won't be necessary but if it turns out they are you can set a config to do it automatically

It looks like that could do the trick 👍

[wolfv]

I didn't see all the new comments and modified stuff to use mamba.bat directly. However, that didn't work either so feel free to revert that

[dhirschfeld]

I had a play around in #7 but didn't get to the bottom of it :(

Note that the fail-fast: false means that powershell will continue even if a call to an exe fails. This behaviour can be changed by putting $ErrorActionPreference = 'stop'; in each script.
https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference

This caused me some confusion when I thought the Run /./ task had failed but it had an error in the activation.
https://github.com/TheSnakePit/setup-mamba/pull/7/checks?check_run_id=765337498#step:4:4

When I instrument the script with mamba --version I get a result:

mamba 0.3.3
conda 4.8.3

...which is quite strange because mamba install definitely doesn't seem to work.

When I tried with Start-Process I didn't even get an exit code which I suspect means the process wasn't even started. Not sure.

I don't know why version would work and not install? I suspect maybe version doesn't hit any C++ code whereas install does?

I not too sure how you could debug further short of exec'ing into the container and trying out the mamba command to see what actually does happen.