Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong activated PATH in micromamba shell #2722

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Aug 1, 2023

Adding a test for it... 🚧

@AntoinePrv AntoinePrv requested a review from jonashaag August 1, 2023 09:09
@AntoinePrv AntoinePrv linked an issue Aug 1, 2023 that may be closed by this pull request
@AntoinePrv AntoinePrv requested a review from Hind-M August 1, 2023 10:23
@AntoinePrv AntoinePrv requested a review from jonashaag August 1, 2023 10:53
Copy link
Contributor

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@AntoinePrv AntoinePrv merged commit 58acf67 into mamba-org:main Aug 1, 2023
@AntoinePrv AntoinePrv deleted the fix-shell-path branch August 1, 2023 12:31
cvanelteren pushed a commit to cvanelteren/mamba that referenced this pull request Aug 29, 2023
* Fix wrong activated PATH in micromamba shell

* Add PATH check for shell activation

* Simplify stdout check in shell test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

micromamba shell broken since 1.4.5
3 participants