Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mamba init fish #2006

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Support for mamba init fish #2006

merged 1 commit into from
Oct 11, 2022

Conversation

dlukes
Copy link
Contributor

@dlukes dlukes commented Oct 11, 2022

See #1718 for details.

mamba/setup.py Show resolved Hide resolved
Copy link
Contributor

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we can somehow deduplicate the function micromamba code with the stuff in mamba.fish

@dlukes
Copy link
Contributor Author

dlukes commented Oct 11, 2022

I wonder if we can somehow deduplicate the function micromamba code with the stuff in mamba.fish

Yeah, I thought about that too. They'd probably have to be generated from a template in a build step. Note it's not just the name that's different, one invokes just $MAMBA_EXE, the other one alternates between $MAMBA_EXE and $CONDA_EXE.

But then I thought -- realistically, these are unlikely to change often, so probably not worth the added complexity, and better keep it simple.

Let me know if you think otherwise though.

@wolfv
Copy link
Member

wolfv commented Oct 11, 2022

Yeah, I think it's not worth the effort right now :) Thanks for making the PR! Now we just need the same for Powershell (#1088)

@wolfv wolfv merged commit 6213080 into mamba-org:main Oct 11, 2022
Hind-M pushed a commit to Hind-M/mamba that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants