Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some of the dev dependencies to the top level #114

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

fcollonval
Copy link
Member

Fixes #112

@github-actions
Copy link

Binder 👈 Launch a binder notebook on the branch mamba-org/gator/fcollonval/issue112

@coveralls
Copy link

Pull Request Test Coverage Report for Build 388789937

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.983%

Totals Coverage Status
Change from base Build 388773498: 0.0%
Covered Lines: 745
Relevant Lines: 1002

💛 - Coveralls

@fcollonval fcollonval merged commit 0ad6ce7 into master Nov 29, 2020
@fcollonval fcollonval deleted the fcollonval/issue112 branch November 29, 2020 09:11
@jtpio
Copy link
Member

jtpio commented Nov 30, 2020

Thanks @fcollonval!

Do you think it would also make sense to move the eslint and prettier scripts to the top-level?

For example:

"eslint": "eslint . --fix --ext .ts,.tsx",
"eslint:check": "eslint . --ext .ts,.tsx",

@fcollonval
Copy link
Member Author

Do you think it would also make sense to move the eslint and prettier scripts to the top-level?

Sure, maybe specifying packages as the folder argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some of the dev dependencies to the top level
3 participants