Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic notebook extension with 2.0.0 #115

Closed
jtpio opened this issue Nov 30, 2020 · 2 comments · Fixed by #116
Closed

Classic notebook extension with 2.0.0 #115

jtpio opened this issue Nov 30, 2020 · 2 comments · Fixed by #116
Assignees

Comments

@jtpio
Copy link
Member

jtpio commented Nov 30, 2020

Description

It looks like the classic notebook extension is not installed automatically with the latest 2.0.0 release.

Reproduce

  1. mamba create -n test -c conda-forge python -y
  2. pip install mamba-gator
  3. jupyter nbextension list
$ jupyter nbextension list
Known nbextensions:
  config dir: /home/jtp/miniforge3/envs/test/etc/jupyter/nbconfig
    notebook section
      mamba_gator/static/main  enabled
      - Validating: problems found:
        - require?  X mamba_gator/static/main
    tree section
      mamba_gator/static/tree  enabled
      - Validating: problems found:
        - require?  X mamba_gator/static/tree
@jtpio
Copy link
Member Author

jtpio commented Nov 30, 2020

Ah it's probably because the config points to the file under the static dir:

"mamba_gator/static/main": true

While they are at the top level in the navigator folder:

https://github.com/mamba-org/gator/tree/0ad6ce7f9a73577bb9503ba64e59e12271e5952c/mamba_gator/navigator

@fcollonval
Copy link
Member

Thanks for catching that one. Too much trial to use the same bundle for notebook and the navigator 😞

When fixing it, it would be good to restore the original test checking the conda tab exists: https://github.com/mamba-org/gator/blob/v3.4.1/jupyter_conda/tests/js/test_notebook_basic.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants