This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Fix pin_compatible #325
Merged
Fix pin_compatible #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test to the boa build recipes.
ruben-arts
changed the title
|
just to be sure, was this test failing before? because it looks like it might still succeed? |
|
Yes @wolfv, before the change you could not have run boa having a pin_compatible in you recipe. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this issue when I was trying to upgrade to a newer version of boa, going from
0.7.1directly to0.14.0not sure when this stopped working.Added test to the boa build recipes. The test is pretty specific to my use case but my knowledge on the pin compatible mechanism is too small to make any more meaning full test.