Skip to content

Commit

Permalink
always set 'use_default_shell_env' in ctx.actions.run
Browse files Browse the repository at this point in the history
Aspect uses shell wrappers that invoke tools like `dirname` and `uname`.
When the default shell env is not inherited, this prevents tools from
being found on systems without a working fallback $PATH (like NixOS).

See also: NixOS/nixpkgs#289505
  • Loading branch information
malt3 committed Jun 4, 2024
1 parent 8c1f40a commit 4039cd4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions esbuild/private/esbuild.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ def _esbuild_impl(ctx):
execution_requirements = execution_requirements,
mnemonic = "esbuild",
env = env,
use_default_shell_env = True,
executable = launcher,
)

Expand Down

0 comments on commit 4039cd4

Please sign in to comment.