fix: Throwing errors with superjson (msw 2) #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maloguertin could you kindly take a look? It's blocking our upgrade to msw 2 |
|
Why is this not being merged? |
|
Is this project still being maintained? |
|
I also wish this PR to be merged soon. |
|
Any chance of this being merged? Is this still being maintained? @maloguertin |
maloguertin
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
Closes #35
Closes #13
🎯 Changes
Fix: Error object should be serialized by superjson on the server
Fix:
error.data.pathshould be populatedI had to manually match the error object because
toThrowonly checks the error type and message, not its content✅ Checklist