Skip to content

Commit

Permalink
Merge pull request #2008 from malloydata/renderer-knowledge-transfer
Browse files Browse the repository at this point in the history
fix: render value null check
  • Loading branch information
skokenes authored Nov 13, 2024
2 parents 2dcb325 + fd32f17 commit 0b3a45e
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,10 @@ const populateFieldMeta = (data: DataArray, metadata: RenderResultMetadata) => {
const fieldSet = maxUniqueFieldValueSets.get(getFieldKey(f))!;

const value = f.isAtomicField() ? row.cell(f).value : undefined;
if (value === null || typeof value === 'undefined') {
if (
f.isAtomicField() &&
(value === null || typeof value === 'undefined')
) {
fieldMeta.values.add(NULL_SYMBOL);
fieldSet.add(NULL_SYMBOL);
} else if (valueIsNumber(f, value)) {
Expand Down

0 comments on commit 0b3a45e

Please sign in to comment.