Skip to content

Commit

Permalink
a bit more fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
malkia committed Nov 20, 2024
1 parent 521fd4a commit 2228610
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions x/bazel/grpc_ares_fix_2.diff
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/src/core/lib/event_engine/windows/grpc_polled_fd_windows.cc b/src/core/lib/event_engine/windows/grpc_polled_fd_windows.cc
index 37a8f85cc5..b319f17aaf 100644
--- a/src/core/lib/event_engine/windows/grpc_polled_fd_windows.cc
+++ b/src/core/lib/event_engine/windows/grpc_polled_fd_windows.cc
@@ -224,7 +224,7 @@ class GrpcPolledFdWindows : public GrpcPolledFd {
// c-ares overloads this recv_from virtual socket function to receive
// data on both UDP and TCP sockets, and from is nullptr for TCP.
if (from != nullptr) {
- CHECK(*from_len <= recv_from_source_addr_len_);
+ CHECK(*from_len >= recv_from_source_addr_len_);
memcpy(from, &recv_from_source_addr_, recv_from_source_addr_len_);
*from_len = recv_from_source_addr_len_;
}
diff --git a/src/core/resolver/dns/c_ares/grpc_ares_ev_driver_windows.cc b/src/core/resolver/dns/c_ares/grpc_ares_ev_driver_windows.cc
index ef70bfc5b6..e8b05452c7 100644
--- a/src/core/resolver/dns/c_ares/grpc_ares_ev_driver_windows.cc
+++ b/src/core/resolver/dns/c_ares/grpc_ares_ev_driver_windows.cc
@@ -73,7 +73,7 @@ namespace {
// instantiated at the top of the virtual socket function callstack.
class WSAErrorContext final {
public:
- explicit WSAErrorContext(){};
+ explicit WSAErrorContext() {};

~WSAErrorContext() {
if (error_ != 0) {

0 comments on commit 2228610

Please sign in to comment.