Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes documentation #6

Merged
merged 8 commits into from
Dec 30, 2022
Merged

Completes documentation #6

merged 8 commits into from
Dec 30, 2022

Conversation

agalbachicar
Copy link
Collaborator

🎉 New feature

Part of #1

Summary

Goes on top of #5 and completes the missing documentation of #4.

Test it

Via unit tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@agalbachicar agalbachicar mentioned this pull request Dec 29, 2022
Open
22 tasks
francocipollone
francocipollone approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agalbachicar
Fixes EOL in many files.
d97ec93 
Signed-off-by: Agustin Alba Chicar <[email protected]>
@agalbachicar
Initial package implementation.
a97905d 
- Provides a package with message descriptions for RoadGeometry, BranchPoint, Junction, Lane and Segment Ids.

Signed-off-by: Agustin Alba Chicar <[email protected]>
@agalbachicar
Adds a translation interface package.
65d269f 
Signed-off-by: Agustin Alba Chicar <[email protected]>
@agalbachicar agalbachicar mentioned this pull request Dec 30, 2022
Merged
6 tasks
@agalbachicar agalbachicar force-pushed the agalbachicar/#1_complete_documentation branch from 0c6916f to 0c9a85f Compare December 30, 2022 15:54
@agalbachicar agalbachicar merged commit 76e0f53 into main Dec 30, 2022
@agalbachicar agalbachicar deleted the agalbachicar/#1_complete_documentation branch December 30, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francocipollone francocipollone francocipollone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agalbachicar @francocipollone