Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses ros-action-ci in build.yaml workflow. #59

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Jun 7, 2022

@francocipollone
Copy link
Collaborator Author

I've been trying this feature of the ros-action-ci but it doesn't seem to be working: https://github.com/ros-tooling/action-ros-ci#interdependent-pull-requests-or-merge-requests

@agalbachicar
Copy link
Collaborator

I've been trying this feature of the ros-action-ci but it doesn't seem to be working: https://github.com/ros-tooling/action-ros-ci#interdependent-pull-requests-or-merge-requests

I've seen it in a code block. Have you tried it?

@francocipollone
Copy link
Collaborator Author

I've been trying this feature of the ros-action-ci but it doesn't seem to be working: https://github.com/ros-tooling/action-ros-ci#interdependent-pull-requests-or-merge-requests

I've seen it in a code block. Have you tried it?

Let's see

@francocipollone
Copy link
Collaborator Author

image
@agalbachicar Nope, I will continue checking

Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me as reviewer when you've found a solution. Otherwise, I can allocate some time to investigate further.

@francocipollone francocipollone force-pushed the francocipollone/build_ros_action_ci branch from 9669f64 to bfe9368 Compare June 9, 2022 18:47
@francocipollone francocipollone force-pushed the francocipollone/build_ros_action_ci branch from bfe9368 to 589d703 Compare June 9, 2022 19:08
@francocipollone
Copy link
Collaborator Author

francocipollone commented Jun 9, 2022

It is working now! @agalbachicar

image

Some things to have mind with this tool

  • When using action-ros-ci-repos-override, the entire repos file is being overridden, meaning that all the repos should be added to the repos file.
  • It only works for Github Action triggered via pull_request.
  • If PR's description has changed, then retriggering the workflow from Action tab doesn't seem to work (The PR's description is not updated for the action). You have to push again to the branch. (It could be an undesired behavior to report)

For the record:

I've found some PRs(See here) where this was being used (By the very feature's creator) and from there I got the confirmation on the expected PR's description syntaxis.

@agalbachicar
Copy link
Collaborator

I suggest we add a TODO in maliput_documentation and explain how to use it in the developer guidelines.

Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone
Copy link
Collaborator Author

I suggest we add a TODO in maliput_documentation and explain how to use it in the developer guidelines.

Done! maliput/maliput_documentation#91

Going in

@francocipollone francocipollone merged commit a4fbac0 into main Jun 9, 2022
@francocipollone francocipollone deleted the francocipollone/build_ros_action_ci branch June 9, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants