Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes maliput_drake dependency. #105

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Removes maliput_drake dependency. #105

merged 3 commits into from
Sep 27, 2023

Conversation

francocipollone
Copy link
Collaborator

🎉 New feature

Summary

Context: maliput_drake has been moved into maliput

  • This PR, removes the maliput_drake dependency and points to maliput::drake

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Removes maliput_drake dependency.
c101962 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone
Copy link
Collaborator Author

CI expected to fail until maliput/maliput#587 is merged

@francocipollone francocipollone mentioned this pull request Sep 20, 2023
Closed
12 tasks
@francocipollone francocipollone marked this pull request as ready for review September 21, 2023 11:37
agalbachicar
agalbachicar approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit c0294d7 into main Sep 27, 2023
3 checks passed
@francocipollone francocipollone deleted the francocipollone/removes_maliput_drake_dep branch September 27, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

@stonier stonier Awaiting requested review from stonier

Assignees
No one assigned
Labels
None yet
Projects
Maliput - Core development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar