Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curbs to the builder. #274

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

agalbachicar
Copy link
Collaborator

🎉 New feature

Part of #265 and #260

Summary

The xodr map in 6c8d624 has lanes with curb types which we don't support yet. This PR addresses that.

Test it

Via unit tests. And checked that now the curbs can be parsed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Agustin Alba Chicar <[email protected]>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agalbachicar agalbachicar merged commit b6774cc into main Feb 19, 2024
5 checks passed
@agalbachicar agalbachicar deleted the agalbachicar/#265_add_curb_to_lane_types branch February 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants