-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements inertial_to_backend_frame_translation #35
Implements inertial_to_backend_frame_translation #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -69,20 +69,25 @@ api::LanePosition Lane::DoEvalMotionDerivatives(const api::LanePosition&, const | |||
} | |||
|
|||
api::InertialPosition Lane::DoToInertialPosition(const api::LanePosition& lane_pos) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little confused here. The docstring in https://github.com/ToyotaResearchInstitute/maliput/pull/401/files indicates that this method should only be overriden when "the Inertial and Backend Frames do not differ". Yet, the use of segment()->junction()->road_geometry()->inertial_to_backend_frame_translation()
indicates that they may differ.
Per discussion during meeting just now, if we provide dragway-specific support for an inertial-to-backend transform, it should have no run-time overhead. That is, the in-memory representation should be modified to account for the inertial frame. Thus, the only overhead should be at RoadNetwork initialization time. |
@liangfok note that dragway does not use What do you think? |
We'll keep it as is and change it if required in the future. |
Okay. |
Pairs with maliput/maliput#401