Adds some Intersection/IntersectionBook API & bindings. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <[email protected]>
This was referenced May 7, 2024
francocipollone
changed the title
agalbachicar
requested changes
May 10, 2024
maliput-sys/src/api/api.h
Outdated
|
|
||
| // IntersectionBook_GetIntersections | ||
| std::vector<MutIntersectionPtr>& IntersectionBook_GetIntersections(IntersectionBook& intersection_book) { | ||
| static std::vector<MutIntersectionPtr> intersections; |
There was a problem hiding this comment.
Is it correct? Wouldn't be mixing things if we load two road networks throughout the lifetime of a program?
I don't remember how we are using now libraries, but this could also be a shared library used by two programs simultaneously, right? That could end up in the same data leak.
There was a problem hiding this comment.
Good point. I will find a workaround
Signed-off-by: Franco Cipollone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related to :
maliput::api::RoadNetwork#35Summary
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.