Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds maliput-sys package and basic bindings. #6

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Adds maliput-sys package and basic bindings. #6

merged 3 commits into from
Jan 9, 2024

Conversation

francocipollone
Copy link
Contributor

🎉 New feature

Goes on top of #5
Closes #3

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone francocipollone mentioned this pull request Jan 8, 2024
Merged
6 tasks
agalbachicar
agalbachicar previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM due to logistics. I'll get back to it later this week.

Base automatically changed from francocipollone/maliput-sdk to main January 9, 2024 20:19
@francocipollone francocipollone dismissed agalbachicar’s stale review January 9, 2024 20:19

The base branch was changed.

@francocipollone francocipollone merged commit 94bc5d3 into main Jan 9, 2024
2 checks passed
@francocipollone francocipollone deleted the francocipollone/maliput-sys branch January 9, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar left review comments

@stonier stonier Awaiting requested review from stonier

Assignees
No one assigned
Labels
maliput-sys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maliput-sys] Create package for bindings and minimal bindings
2 participants
@francocipollone @agalbachicar