Get lane id from clicked lane #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
previously approved these changes
Aug 2, 2019
| @@ -101,6 +104,9 @@ class MaliputViewerModel { | |||
| /// \param[in] _isVisible The new visualization status of the text label. | |||
| void SetTextLabelState(MaliputLabelType _type, bool _isVisible); | |||
|
|
|||
| const maliput::api::Lane* GetLaneFromWorldPosition( | |||
There was a problem hiding this comment.
@BMarchi nit: missing documentation block
There was a problem hiding this comment.
nit: consider changing point with position or simply removing it when redundant
| if (_e->button() == Qt::LeftButton) | ||
| { | ||
| const ignition::rendering::RayQueryResult& rayResult = | ||
| this->orbitViewControl->GetQueryResult(); |
There was a problem hiding this comment.
@BMarchi indent four spaces here
| @@ -79,6 +80,8 @@ class RenderMaliputWidget : public QWidget { | |||
| /// \param[in] _e The event that happened. | |||
| virtual void paintEvent(QPaintEvent* _e); | |||
|
|
|||
| signals: void VisualClicked(ignition::rendering::RayQueryResult rayResult); | |||
There was a problem hiding this comment.
@BMarchi nit: missing documentation block
| @@ -77,6 +77,8 @@ class OrbitViewControl { | |||
| /// \param[in] _e The Qt mouse event. | |||
| void OnMouseWheel(const QWheelEvent* _e); | |||
|
|
|||
| const ignition::rendering::RayQueryResult& GetQueryResult() const; | |||
There was a problem hiding this comment.
@BMarchi nit: missing documentation block
hidmic
previously approved these changes
Aug 2, 2019
| @@ -101,6 +104,9 @@ class MaliputViewerModel { | |||
| /// \param[in] _isVisible The new visualization status of the text label. | |||
| void SetTextLabelState(MaliputLabelType _type, bool _isVisible); | |||
|
|
|||
| const maliput::api::Lane* GetLaneFromWorldPosition( | |||
There was a problem hiding this comment.
nit: consider changing point with position or simply removing it when redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the moment, this works for the maliput viewer. I wanted to use only the maliput viewer model to gather the information but since it's not a QObect, I had to use the widget as a intermediary