Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] drop the unused lcm interface #408

Merged
merged 4 commits into from
May 15, 2018
Merged

Conversation

stonier
Copy link
Collaborator

@stonier stonier commented May 11, 2018

Started going down the rabbit hole of working out what vestige of LCM we are actually stuck with, but cut it short for now, just dropping the interface from the automotive simulator.

Part of #398

@stonier stonier requested a review from basicNew May 11, 2018 22:49
@stonier stonier mentioned this pull request May 11, 2018
37 tasks
Copy link

@apojomovsky apojomovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a (very) minor style comment, otherwise LGTM.
Tested it and everything works as expected.

// ignition position message.
//
// @param[in] lcm_position The LCM position array.
// @param[in] position the position array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The should go uppercase

@stonier stonier merged commit 17d1e7a into master May 15, 2018
@stonier stonier deleted the stonier/lcm_interface branch May 15, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants