-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add german desktop terminal layout #236
base: master
Are you sure you want to change the base?
Conversation
1dc595e
to
76d7477
Compare
76d7477
to
abd6da3
Compare
1c50e6d
to
9854353
Compare
Hey, how is it going with this PR? This adds very useful keys that I need to be able to use In fact, this is exactly what I've been looking for. |
@Anachron I'm currently struggling to get the ctrl key working as intended, but other than that it works perfectly fine. I'm currently thinking about removing the ctrl for now and adding it with a different PR once I figured out how to do that. |
@a-st so the I am hoping we can get this keyboard to something that is actually useful as a real keyboard for daily working. I have no knowledge in c++, but maybe I could help building/testing it on real hardware. |
@Anachron I have no knowledge in c or c++, either. Nor do I know any QT or QML development. Any help is highly appreciated. Getting something similar to the Windows 11 on-screen keyboard would be nice |
I was checking the modifications briefly. You've added Checking https://github.com/maliit/keyboard/blob/master/plugins/de/qml/Keyboard_de.qml#L88-L94 it never renames these keys, this is across all locales (at least those I checked, Edit: Guess what I am trying to say is: Lets keep their names at Edit2: I don't think that could be an issue. Label is not matched. No idea what the issue would be. I will see if I can get this PR to run on my setup and will report back if it works here... |
Maybe I wasn't clear, as far as I can tell, the Ctrl command is send but it does not yet behave like a sticky key, e.g. like the Shift key. I tried to make the Ctrl key stay in pressed state until another key is pressed but so far I didn't manage to get it to work |
Ah thanks for the clarification, that is Indeed helpful, I think I saw some differences between shift and control behavior in your PR. Edit: By skimming over https://github.com/maliit/keyboard/pull/236/files#diff-aa8c36e303e82024c5bfc629f9014bb61314d6463cebdc1eb8965ce80c82d197R48-R55 shouldn't that be something like https://github.com/maliit/keyboard/blob/master/qml/keys/ShiftKey.qml#L33-L67? |
Adds german desktop terminal layout (based on #230)