Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default install instructions for runtime dependencies #49

Merged
merged 7 commits into from
Jul 14, 2021

Conversation

malept
Copy link
Owner

@malept malept commented Jul 14, 2021

Description of Change

Export default install instructions for runtime dependencies (wine, mono), so that they can be used when generating custom wrapperInstructions arguments.

Export WrapperError in the event that a downstream dependency wants to update the error message via an instanceof check in a catch block.

Also do some cleanup around using nullish coalescing operators.

Checklist

  • I have read the contribution documentation for this project.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #49 (3d9ac49) into main (be28e7a) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   96.10%   96.34%   +0.23%     
==========================================
  Files           5        5              
  Lines          77       82       +5     
  Branches       20       23       +3     
==========================================
+ Hits           74       79       +5     
  Partials        3        3              
Impacted Files Coverage Δ
src/dotnet.ts 100.00% <100.00%> (ø)
src/exe.ts 100.00% <100.00%> (+10.00%) ⬆️
src/wrapper.ts 93.93% <100.00%> (-6.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be28e7a...3d9ac49. Read the comment docs.

@malept malept merged commit 21e97b6 into main Jul 14, 2021
@malept malept deleted the feat/exported-install-instructions branch July 14, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant