Fixed wrong behavior of dateAt(.startOfMonth) #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your great library 😀
Any suggestions and thoughts will be appreciated :)
I think it's odd that two similar helper functions have different results.
For example
We can not define the exact moments of endOfDay, endOfWeek, endOfMonth (depending on the minimum time unit you set).
However, it's so clear that startOfDay, startOfWeek, startOfMonth represent certain point in time which is
yyyy-MM-dd 00:00:00
.So that's why
dateAt(.startOfMonth)
,dateAtStartOf(.month)
should have same results.(and it's already same in .startOfDay, .startOfWeek)