Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Decodable protocol in DateInRegion/Region on Swift 4.2 #559

Closed
sedwo opened this issue Jul 12, 2018 · 7 comments
Closed

Fixes for Decodable protocol in DateInRegion/Region on Swift 4.2 #559

sedwo opened this issue Jul 12, 2018 · 7 comments
Assignees
@malcommac
Labels
bug
Milestone
5.0.4

Comments

@sedwo
Copy link

sedwo commented Jul 12, 2018

Just did a pod update and it broke my project.

image
@vaibhav-varshaaweblabs
Copy link

vaibhav-varshaaweblabs commented Jul 18, 2018 •
edited
Loading

Same here

@sedwo Found any fix for that?

@malcommac
Copy link
Owner

malcommac commented Jul 18, 2018 •
edited
Loading

What's happens if you try to replace Codable with Decodable (both in DateInRegion and Region)? I can't reproduce this issue but if it could be a fix I'm ready to publish an hotfix.

malcommac added a commit that referenced this issue Jul 18, 2018
@malcommac
#559 Fixed Codable compiling issue on Swift 4.2, Added identifier_nam…
d5be0a9 
…e rule in SwiftLint
@malcommac malcommac changed the title Type 'DateInRegion' does not conform to protocol 'Decodable' Fixes for Decodable protocol in DateInRegion/Region on Swift 4.2 Jul 18, 2018
@malcommac malcommac self-assigned this Jul 18, 2018
@malcommac malcommac added the bug label Jul 18, 2018
@malcommac malcommac added this to the 5.0.4 milestone Jul 18, 2018
@sedwo
Copy link
Author

sedwo commented Jul 18, 2018 •
edited
Loading

@malcommac Well, it still seems to fail for me in the same way. Simply using your example app.
Running Sierra and Xcode 9.2.
I'll monitor it.

@vaibhav-varshaaweblabs
Copy link

vaibhav-varshaaweblabs commented Jul 19, 2018 •
edited
Loading

Same here

MacOS Sierra - Version 10.12.6 (16G1036)
XCode - Version 9.2 (9C40b)

screen shot 2018-07-19 at 12 51 09 pm

@Bawenang
Copy link

Hi, I'm using 5.0.7 and this bug is still there.

MacOS Sierra - Version 10.12.6
XCode - Version 9.0

@malcommac
Copy link
Owner

Sure it still here, you need to update to 5.0.9, otherwise you still get the same problem :)

@waploaj
Copy link

waploaj commented Apr 18, 2019

Sure it still here, you need to update to 5.0.9, otherwise you still get the same problem :)

Hi, i'm using 6.0.1 and this bug is still here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malcommac malcommac

Labels
bug
Projects
None yet
Milestone
5.0.4
Development

No branches or pull requests
5 participants
@malcommac @sedwo @Bawenang @waploaj @vaibhav-varshaaweblabs