Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdeModulePkg: Test change in DxeMain #182

Closed
wants to merge 10 commits into from

Conversation

makubacki
Copy link
Owner

Description

Test change for PR reviewer automation.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

N/A

Integration Instructions

N/A

@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 0cdd370 to e6c4a36 Compare July 22, 2024 22:09
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from e6c4a36 to 7eda949 Compare July 22, 2024 22:13
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 7eda949 to 8d3de11 Compare July 22, 2024 22:19
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 8d3de11 to 34813f0 Compare July 22, 2024 22:24
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 34813f0 to 8b1471b Compare July 22, 2024 22:28
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 8b1471b to a767a64 Compare July 22, 2024 22:33
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from a767a64 to a8b5462 Compare July 22, 2024 22:37
@makubacki makubacki closed this Jul 22, 2024
@makubacki makubacki reopened this Jul 22, 2024
Copy link

WARNING: Cannot add reviewers: A user specified as a reviewer for this PR is not a collaborator of the edk2 repository. Please add them as a collaborator to the repository and re-request the review.

Users requested:
ajfish, leiflindholm, mdkinney, uefibot, spbrogan

Adds a new `-g` parameter so that output will also include the GitHub
username.

This change uses a simple regular expression as opposed to directly
returning the original line from the file to make the extraction of
GitHub usernames more robust to other changes on the line in the
maintainers text file.

Signed-off-by: Michael Kubacki <[email protected]>
Adds a script that provides GitHub API helpers for workflows and
other GitHub automation in the repository.

Signed-off-by: Michael Kubacki <[email protected]>
Adds a new GitHub workflow to automatically add reviewers to pull
requests when they are opened, reopened, synchronized, and if a draft
pull request is marked as ready for review. The workflow will not
run on draft pull requests.

The workflow is meant to be simple to understand and modify, relying
on existing logic in GetMaintainer.py to determine the relevant
reviewers and using simple Python GitHub REST API wrappers with the
default GitHub token for authentication.

Future changes may optimize the workflow.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 6d2a090 to 27071d8 Compare July 24, 2024 23:56
@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 20f255a to 7b517fd Compare July 25, 2024 00:00
Copy link

WARNING: Cannot add reviewers: A user specified as a reviewer for this PR is not a collaborator of the edk2 repository. Please add them as a collaborator to the repository and re-request the review.

Users requested:
ajfish, javagedes, leiflindholm, mdkinney, uefibot, spbrogan

@makubacki makubacki force-pushed the auto_pr_reviewers_pr_test_1 branch from 46020e2 to e4a9dd0 Compare July 25, 2024 00:37
@makubacki
Copy link
Owner Author

Closing. Testing Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant