add OpenShift support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 98.59% 98.71% +0.12%
==========================================
Files 6 7 +1
Lines 213 234 +21
==========================================
+ Hits 210 231 +21
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Azure offers [Red Hat OpenShift](https://azure.microsoft.com/en-us/products/openshift/), and clients can also deploy a self-managed cluster. The nodes of this cluster can handle the [Azure Metadata Service](https://learn.microsoft.com/en-us/azure/virtual-machines/linux/scheduled-events) in the same way as [AKS](https://azure.microsoft.com/en-us/products/kubernetes-service) managed nodes. The difference is that AKS uses `virtualMachineScaleSets`, while OpenShift and self-managed cluster uses `virtualMachines` for their nodes. This change can help Azure customers that use OpenShift or self-managed kubernetes clusters for their infrastucture. Closes: #75 Signed-off-by: Maksim Paskal <[email protected]>
maksim-paskal
force-pushed
the
add-openshift-providerID
branch
from
f0da894 to
ac0b332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure offers Red Hat OpenShift, and clients can also deploy a self-managed cluster. The nodes of this cluster can handle the Azure Metadata Service in the same way as AKS managed nodes.
The difference is that AKS uses
virtualMachineScaleSets, while OpenShift and self-managed cluster usesvirtualMachinesfor their nodes.This change can help Azure customers that use OpenShift or self-managed kubernetes clusters for their infrastucture.
Closes: #75