fix: fix eslint warning

makotot · Mar 4, 2021 · 9b1a662 · 9b1a662
1 parent 1736540
commit 9b1a662
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 6 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -0,0 +1,12 @@
+module.exports = {
+  extends: [
+    'react-app',
+    'prettier/@typescript-eslint',
+    'plugin:prettier/recommended',
+  ],
+  settings: {
+    react: {
+      version: 'detect',
+    },
+  },
+};
diff --git a/example/App.tsx b/example/App.tsx
@@ -27,7 +27,7 @@ export const App: React.FC<{
         </div>
         <Grid>
           {props.hasPrev() && (
-            <a href="#" data-testid="hasPrev">
+            <a href="#prev" data-testid="hasPrev">
               prev
             </a>
           )}
@@ -55,7 +55,7 @@ export const App: React.FC<{
                   {page}
                 </span>
               ) : (
-                <a href="#" key={page} data-testid="pageItems">
+                <a href="#page" key={page} data-testid="pageItems">
                   {page}
                 </a>
               );
@@ -72,7 +72,7 @@ export const App: React.FC<{
             );
           })}
           {props.hasNext() && (
-            <a href="#" data-testid="hasNext">
+            <a href="#next" data-testid="hasNext">
               next
             </a>
           )}

diff --git a/src/usePaginated.ts b/src/usePaginated.ts
@@ -36,7 +36,14 @@ export const usePaginated: UsePaginated = ({
         currentPage + siblingsSize
       )
     );
-  }, [currentPage, siblingsSize, displayPageItemsSize]);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [
+    isReachedToFirst,
+    isReachedToLast,
+    currentPage,
+    siblingsSize,
+    displayPageItemsSize,
+  ]);
 
   const hasPrev = useCallback(() => currentPage > 1, [currentPage]);
   const hasNext = useCallback(() => totalPage > currentPage, [
@@ -61,7 +68,13 @@ export const usePaginated: UsePaginated = ({
       .filter(p => !pages.includes(p));
 
     return boundary;
-  }, [pages]);
+  }, [
+    boundarySize,
+    isReachedToFirst,
+    pages,
+    prevAllPages.length,
+    totalPageItems,
+  ]);
 
   const getLastBoundary = useCallback(() => {
     if (isReachedToLast()) {
@@ -74,7 +87,13 @@ export const usePaginated: UsePaginated = ({
       .slice(totalPageItems.length - boundarySize, totalPageItems.length)
       .filter(p => !pages.includes(p));
     return boundary;
-  }, [pages]);
+  }, [
+    boundarySize,
+    isReachedToLast,
+    nextAllPages.length,
+    pages,
+    totalPageItems,
+  ]);
 
   const isPrevTruncated =
     prevAllPages.filter(