-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpolateOnLine doesn't return correct predecessor #66
Comments
Thanks for reporting! This should be fairly to reproduce in a test case. Would you mind submitting a pull-request? |
Hi, |
I have a fix for this, but I get a 403 when trying to submit a pull request. |
Do you create a PR from a private repo ? I can't see your fork in your repositories. |
My bad, I cloned it to my computer from URL. PR created, thanks for pointing me in the right direction. |
Thank you @jb2b38 for your PR. @eric7472 @luiscamachopt could you check if the fix made by @jb2b38 fix your bug ? Please clone https://github.com/jb2b38/Leaflet.GeometryUtil/tree/fix_66 . |
Just for a link to be made between issue & PR : #76 |
* Fix `interpolateOnLine()` doesn't return correct predecessor (#66, thanks @jb2b38) * Add `angle()` and `destinationOnSegment()` (#71, thanks @trandaison) * migrate mocha to 5.2.0 following instructions on npm audit
L.GeometryUtil.interpolateOnLine(myw.app.map, [L.latLng(1, 2), L.latLng(3, 4)], 0.5).predecessor
returns -1 when it should be 0
This happens when point is in first segment.
The text was updated successfully, but these errors were encountered: