Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #110 Error: Expected 'styles' to be an array of strings. #112

Closed
makimenko opened this issue Sep 13, 2019 · 4 comments
Closed

PR #110 Error: Expected 'styles' to be an array of strings. #112

makimenko opened this issue Sep 13, 2019 · 4 comments
Labels

Comments

@makimenko
Copy link
Owner

Hi, @ComFreek
It seems that #110 causing failures in the Storybook:
Error: Expected 'styles' to be an array of strings.

image

See https://makimenko.github.io/angular-template-for-threejs/storybook/?path=/story/actor--actors

@makimenko
Copy link
Owner Author

makimenko commented Sep 13, 2019

Commit temporary reverted.

TODOs:

  • revert commit
  • Improve build to catch such things
  • Upgrade dependency version

@makimenko makimenko added the bug label Sep 13, 2019
@ComFreek
Copy link
Collaborator

Oh god, I am deeply sorry! I thought Travis would account for it. I searched a bit for "Storybook.js testing": https://storybook.js.org/docs/testing/react-ui-testing/

Seems those snapshots would be a good first try: https://storybook.js.org/docs/testing/structural-testing/

@makimenko
Copy link
Owner Author

@makimenko
Copy link
Owner Author

Oh god, I am deeply sorry! I thought Travis would account for it. I searched a bit for "Storybook.js testing": https://storybook.js.org/docs/testing/react-ui-testing/

Seems those snapshots would be a good first try: https://storybook.js.org/docs/testing/structural-testing/

Hm.. I spend 1-2h.. and no success - a bit hard to understand instructions :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants