#161: TS1086: An accessor cannot be declared in an ambient context.

- Upgrade to Typescript 3.7.4 + workarounds - angularCompilerOptions.disableTypeScriptVersionCheck=true - added polyfills.ts: __importDefault
makimenko · Dec 27, 2019 · d319384 · d319384
1 parent 80df914
commit d319384
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -66,6 +66,6 @@
     "tsickle": "^0.37.1",
     "tslib": "^1.10.0",
     "tslint": "^5.20.1",
-    "typescript": "3.5.3"
+    "typescript": "3.7.4"
   }
 }
diff --git a/projects/atft/package.json b/projects/atft/package.json
@@ -35,7 +35,7 @@
   "peerDependencies": {
     "@angular/common": "^8.2.2",
     "@angular/core": "^8.2.2",
-    "three": "^0.110.0"
+    "three": "^0.112.0"
   },
   "dependencies": {},
   "engines": {

diff --git a/projects/atft/tsconfig.lib.json b/projects/atft/tsconfig.lib.json
@@ -25,7 +25,8 @@
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "enableResourceInlining": true
+    "enableResourceInlining": true,
+    "disableTypeScriptVersionCheck": true
   },
   "exclude": [
     "src/test.ts",

diff --git a/src/polyfills.ts b/src/polyfills.ts
@@ -32,3 +32,9 @@ import 'zone.js/dist/zone'; // Included with Angular CLI.
 /***************************************************************************************************
  * APPLICATION IMPORTS
  */
+
+// TODO: Remove when Angular will support typescript 3.7+
+// @ts-ignore
+window.__importDefault = function(mod) {
+  return mod && mod.__esModule ? mod : { default: mod };
+};
diff --git a/tsconfig.json b/tsconfig.json
@@ -35,5 +35,8 @@
         "node_modules/core-js/proposals/reflect-metadata"
       ]
     }
+  },
+  "angularCompilerOptions": {
+    "disableTypeScriptVersionCheck": true
   }
 }