Fix users being unable to exit help menu #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable all keybindings that cannot be handled by the Help panel while it is active. This guarantees no other commands steal the focus away from the Help panel, making it impossible to exit it. Signed-off-by: David Jimenez <[email protected]>
Signed-off-by: David Jimenez <[email protected]>
Signed-off-by: David Jimenez <[email protected]>
|
Looks like an elegant solution, thanks. Using those constants is nice too. However, this removes some keybindings that are probably important to keep, like the ones for quitting Amfora. Ideally those would still work. I know it's been a while, sorry about missing the Hacktober fest thing. Let me know if you'd like to continue working on this PR, and I'll take over if not. |
|
I've made some changes so that the quit key is supported. Everything else should be fine. Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore any keypresses that don't have a corresponding binding in the Help page to avoid users triggering keybindings that remove the focus from the Help screen and becoming unable to exit, as Help keybindings are no longer captured correctly.
Rather than adding unnecessary complexity to make the Help page more flexible and capable of handling input events meant for other panels, I opted to restrict the input set to the keybindings that have a corresponding action in the Help page while it's active.
Closes #241 .