#24 - improving tracking logic

makesites · Feb 20, 2013 · 442d035 · 442d035
1 parent 196145f
commit 442d035
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/app.router.js b/lib/app.router.js
@@ -7,8 +7,8 @@
 		},
 		initialize: function(){
 			_.bindAll(this, 'fb_fix');
-			// include this in your router if using Google Analytics
-			// this.bind('all', this._trackPageview);
+			// analytics
+			this.bind('all', this._trackPageview);
 		}, 
 		// Save app state in a seperate object
 		state: {
@@ -29,7 +29,8 @@
 		// Utils
 		_trackPageview: function(){ 
 			var url = Backbone.history.getFragment();
-			if( !_.isUndefined( _gaq ) ) _gaq.push(['_trackPageview', "/#"+url]);
+			// check for Google Analytics
+			if( typeof _gaq != "undefined" ) _gaq.push(['_trackPageview', "/#"+url]);
 		}
 
 	});

diff --git a/lib/app.view.js b/lib/app.view.js
@@ -76,7 +76,7 @@
 			e.preventDefault();
 			var url = this.findLink(e.target);
 			// track the click with Google Analytics (if available)
-			if( !_.isUndefined(pageTracker) ) url = pageTracker._getLinkerUrl(url);
+			if(typeof pageTracker != "undefined") url = pageTracker._getLinkerUrl(url);
 			window.open(url, '_blank'); 
 			return false; 
 		},