Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frenis #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Frenis #21

wants to merge 5 commits into from

Conversation

Denisglb
Copy link

Sharing posts to other social media

Copy link

@maryrosecook maryrosecook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go. Let me know if you have any questions!

@@ -15,6 +15,25 @@
<% end %>

<% @posts_sorted.each do |post| %>
<div id="share-buttons">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SRP: Could this be in a partial?

db/schema.rb Outdated
ActiveRecord::Schema.define(version: 20170920095341) do

# These are extensions that must be enabled in order to support this database
# These are extensions that must be enabled in order to support this database

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out for random accidental whitespace changes. There's one above, as well.

@@ -0,0 +1,14 @@
#share-buttons img {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use idiomatic indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants