-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frenis #21
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you go. Let me know if you have any questions!
app/views/posts/index.html.erb
Outdated
@@ -15,6 +15,25 @@ | |||
<% end %> | |||
|
|||
<% @posts_sorted.each do |post| %> | |||
<div id="share-buttons"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SRP: Could this be in a partial?
db/schema.rb
Outdated
ActiveRecord::Schema.define(version: 20170920095341) do | ||
|
||
# These are extensions that must be enabled in order to support this database | ||
# These are extensions that must be enabled in order to support this database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch out for random accidental whitespace changes. There's one above, as well.
@@ -0,0 +1,14 @@ | |||
#share-buttons img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use idiomatic indentation.
Sharing posts to other social media