Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Replace dapp tools with foundry for spell flattening #248

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Replace dapp tools with foundry for spell flattening #248

wants to merge 1 commit into from

Conversation

SidestreamColdMelon
Copy link
Contributor

Goerli version of the mainnet PR makerdao/spells-mainnet#391

@SidestreamColdMelon
Copy link
Contributor Author

SidestreamColdMelon commented Feb 13, 2024 •
edited
Loading

I was able to deploy and verify previous goerli spell using updated command:

The diff: https://www.diffchecker.com/or989FFL/

The only conflicting interface there is OracleLike, but it's not being used 😞. Not sure if it's enough to validate correctness of the flattening. I guess I need to come up with a spell with a real conflict to properly test this.

@SidestreamColdMelon SidestreamColdMelon marked this pull request as ready for review February 13, 2024 11:35
@SidestreamColdMelon SidestreamColdMelon marked this pull request as draft February 13, 2024 11:39
@SidestreamColdMelon SidestreamColdMelon mentioned this pull request Apr 8, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SidestreamColdMelon