Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Refactor: change testAuth* strategy #238

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Conversation

amusingaxl
Copy link
Collaborator

@amusingaxl amusingaxl commented Dec 18, 2023

This is a port of makerdao/spells-mainnet#374.
Main discussion should happen there.

oddaf
oddaf previously approved these changes Dec 19, 2023
@amusingaxl amusingaxl requested a review from a team December 21, 2023 11:59
@amusingaxl amusingaxl marked this pull request as ready for review December 21, 2023 11:59
0xp3th1um
0xp3th1um previously approved these changes Dec 22, 2023
Copy link
Collaborator

@0xp3th1um 0xp3th1um left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xdecr1pto
0xdecr1pto previously approved these changes Dec 22, 2023
@amusingaxl amusingaxl dismissed stale reviews from 0xdecr1pto and 0xp3th1um via 7daf57c January 18, 2024 19:53
Copy link
Contributor

@SidestreamColdMelon SidestreamColdMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/DssSpell.t.base.sol Outdated Show resolved Hide resolved
src/DssSpell.t.base.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@SidestreamColdMelon SidestreamColdMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the diffs between the diffs (i.e. diffs between git diff master..refactor/optimize-auth-tests executed in two repos) the changes in this PR are now identical to the changes introduced in makerdao/spells-mainnet#374

@amusingaxl amusingaxl merged commit cd91b3e into master Jan 25, 2024
3 checks passed
@amusingaxl amusingaxl deleted the refactor/optimize-auth-tests branch January 25, 2024 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants