This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Update DssSpell.t.base.sol:Enhanced Readability and 'for' loops #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the 'for' loops by changing
i++
to++i
, usage of unchecked blocks anduint256 i = 0;
->uint256 i;
These changes makes the contract cost less gas and are well explained here -> https://gist.github.com/grGred/9bab8b9bad0cd42fc23d4e31e7347144#for-loops-improvement
Also, code readability was improved by correction on line 216 (Take a view of the codebase after this line for a better understanding)
Some typos!
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
Goerli
etherscanmake spell="0x-deployed-spell-address" cast-spell
make archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
andDssSpell.t.base.sol
squash and merge
this PR