2023-10-11 Goerli Spell #231

0xdecr1pto · 2023-10-05T15:45:28Z

Description

Contribution Checklist

PR title starts with (PE-<TICKET_NUMBER>)
Code approved
Tests approved
CI Tests pass

Checklist

…e decrease)

amusingaxl

Goerli Executive Spell Review Checklist

TL;DR: missing RwaLiquidationOracle.bump for changed parameters in RWA007-A and RWA015-A and some nitpicks.

Goerli 2023-10-11

Spell Actions (Per Exec Sheet):

Development Stage

Office Hours
- OFF (On Goerli the deployed spell is cast with a pause delay of 60 sec.)
30 days spell expiry in constructor (block.timestamp + 30 days)
No Exec Doc Hash on Goerli
Spell Description
- Ensure description exactly matches 'Goerli Spell'

Local Environment Actions

Update Foundry by running foundryup

Reinstall libraries by running rm -r lib && git submodule update --init --recursive

Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
Submodule path 'lib/dss-test': checked out '7529fa1e043b9195f41549852d9c5bb0714eaa27'
Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-test/lib/forge-std': checked out 'aea0b2685bebc883c09f5554d7fb481e85d0564d'
Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'

Rate constants used are correct
- Manual check 1: Calculate rates using make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
- ~~Manual check 2: Compare rates used against IPFS rate list~~
- Variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%, SIX_PCT_RATE for 6.00%)
- Visibility is internal
- State mutability is constant
Constants Match
- Precision unit constants used match their defined values
  - RAD = 10 ** 45
  - Visibility is internal
  - State mutability is constant
- Math unit constants used match their defined values
  - MILLION = 10 ** 6
  - BILLION = 10 ** 9
  - Visibility is internal
  - State mutability is constant
String Constants
- IPFS hashes or DAO resolutions
  - IPFS hashes and DAO resolutions match the exec doc
  - The variable is named dao_resolutions
  - if multiple dao resolutions are present
    - they are located in the same string constant and are comma separated
    - The comment above the the variable states: Comma-separated list of DAO resolutions IPFS hashes
- Must be TOP LEVEL (or ds pause will reject)
- Name of the variable matches purpose per EXEC DOC
- Visibility is public
- State mutability MUST BE constant
Core System Parameter Changes
- Stability Fee jug.ilk.duty (setIlkStabilityFee)
  - Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%.
    ⚠️ Math in sheet action description is off.
- Autoline Changes
  - setIlkAutoLineDebtCeiling
    - ilk
    - line
  - setIlkAutoLineParameters
    - ilk
    - line
    - gap
    - ttl
Offboarding (Lerp mat)
- 1st Stage Spell Actions
  - Remove Ilk from Autoline
  - Set Ilks Debt Ceilings to 0
  - Cache Ilks line to Reduce in the Global Debt Ceiling
  - Decrease Global Debt Ceiling by Total Amount of Offboarded Ilks line Cached
RWA Updates
- Autoline (line) + Liquidation Oracle Price Bump (val)
  - Enable Autoline
    - ilk follows format "RWAXXX-A"
    - line (max debt ceiling)
    - gap
    - ttl
  - bump RwaLiquidationOracle with new computed increased price (val)
    ❌ Missing!
    - ensure val is set accordingly with autoline max debt ceiling (line)
    - val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio (see below)
      - New val is calculated with line * [(1 + duty) ** years] * mat - rounded up - and makes sense in context of the rate mechanism. Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding.
      - Comment explaining val formula (Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio) is present
      - Accompanying comment above bump line in format // XXM * 1.XX^X * X.XX as a WAD corresponding to the val calculation formula (e.g. // 15M * 1.03^2 * 1.00 as a WAD) is present along with the calculation formula on the line above
      - IF combining val of multiple RWA ilks being combined, val calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal.
  - Poke spotter to pull in the new price
    ❌ Missing!
- Debt Ceiling (line) + Liquidation Oracle Price Bump (val)
  - Increase Ilk Debt Ceiling (set DC + increase Global DC)
  - bump RwaLiquidationOracle with new computed increased price (val)
    ❌ Missing!
    - val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio (see below)
      - New val is calculated with line * [(1 + duty) ** years] * mat - rounded up - and makes sense in context of the rate mechanism. Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding.
      - Comment explaining val formula (Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio) is present
      - Accompanying comment above bump line in format // XXM * 1.XX^X * X.XX as a WAD corresponding to the val calculation formula (e.g. // 15M * 1.03^2 * 1.00 as a WAD) is present along with the calculation formula on the line above
      - IF combining val of multiple RWA ilks being combined, val calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal.
  - Poke spotter to pull in the new price
    ❌ Missing!
Tests
- Ensure each spell action has sufficient test coverage
  - Non-Scope Defined Parameter Changes - WBTC DC-IAM Changes ✅ testGeneral
  - Stability Fee Changes ✅ testGeneral
  - Initial RETH-A Offboarding ✅ testGeneral
  - Reconfiguring Andromeda RWA015-A ❌ Missing RwaLiquidationOracle.bump test
  - Reconfiguring Clydesdale RWA007-A ❌ Missing RwaLiquidationOracle.bump test
  - USDP-PSM Facilitation Incentives ⚠️ No test coverage. Maybe consider adding it.
- Ensure every test function is declared as public if enabled or private if disabled
- Ensure that the DssExecLib.address file is not being modified by the spell PR
- Check all CI tests are passing as at the latest commit
  ✅ 8e35e7f
- Check all tests are passing locally using make test
  - Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

Using DssExecLib at: 0x122F6c0Dcd898b4a07310E92c3eAE5D7Ce0c8bb6
[⠃] Compiling...
[⠘] Compiling 6 files with 0.8.16
[⠒] Solc 0.8.16 finished in 1.82s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1070878)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 55.89s

Running 17 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 52095774)
[PASS] testAuthInSources() (gas: 8107139)
[PASS] testBytecodeMatches() (gas: 2029961)
[PASS] testCastCost() (gas: 911772)
[PASS] testChainlogValues() (gas: 9287776)
[PASS] testChainlogVersionBump() (gas: 4338863)
[PASS] testContractSize() (gas: 8962)
[PASS] testDeployCost() (gas: 2016529)
[PASS] testFailNotScheduled() (gas: 14397)
[PASS] testFailTooEarly() (gas: 13585)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 37783728)
[PASS] testNextCastTime() (gas: 364790)
[PASS] testOnTime() (gas: 907411)
[PASS] testPSMs() (gas: 2219522)
[PASS] testUseEta() (gas: 363541)
Test result: ok. 17 passed; 0 failed; 0 skipped; finished in 1087.21s
 
Ran 2 test suites: 19 tests passed, 0 failed, 0 skipped (19 total tests)

src/DssSpell.sol

amusingaxl · 2023-10-09T18:15:16Z

src/DssSpell.sol

+        // ---------- Reconfiguring Andromeda RWA015-A  ----------
+        // Forum: https://forum.makerdao.com/t/poll-request-reconfiguring-rwa-allocator-vaults/22159
+        // Poll: https://vote.makerdao.com/polling/QmPoLbah
+


Dangling whitespace:

Suggested change

src/DssSpell.sol

amusingaxl · 2023-10-09T18:53:56Z

src/DssSpell.sol

+        // Set DC-IAM Line (max DC) to 0 (zero). 
+        (,,,uint256 line,) = VatLike(MCD_VAT).ilks("RETH-A");
+        DssExecLib.removeIlkFromAutoLine("RETH-A");
+        DssExecLib.decreaseIlkDebtCeiling("RETH-A", line / RAD, true);


Suggested change

DssExecLib.decreaseIlkDebtCeiling("RETH-A", line / RAD, true);

DssExecLib.decreaseIlkDebtCeiling("RETH-A", line / RAD, /* global = */ true);

src/DssSpell.sol

SidestreamSweatyPumpkin

Goerli Executive Spell Review Checklist

Goerli 2023-10-11

Spell Actions (Per Exec Sheet):

Development Stage

Office Hours
- OFF (On Goerli the deployed spell is cast with a pause delay of 60 sec.)
30 days spell expiry in constructor (block.timestamp + 30 days)
No Exec Doc Hash on Goerli
Spell Description
- Ensure description exactly matches 'Goerli Spell'

Local Environment Actions

Update Foundry by running foundryup

Reinstall libraries by running rm -r lib && git submodule update --init --recursive

Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b25556917
86286cb'
Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f
77'
Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239
a60632a761790b'
Submodule path 'lib/dss-test': checked out '7529fa1e043b9195f41549852d9c5bb0714eaa27'
Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b255569178628
6cb'
Submodule path 'lib/dss-test/lib/forge-std': checked out 'aea0b2685bebc883c09f5554d7fb481e85d0564d'
Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a606
32a761790b'

Rate constants used are correct
- Manual check 1: Calculate rates using make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
- Manual check 2: Compare rates used against IPFS rate list
- Variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%, SIX_PCT_RATE for 6.00%)
- Visibility is internal
- State mutability is constant
Constants Match
- Precision unit constants used match their defined values
  - WAD = 10 ** 18
  - ~~RAY = 10 ** 27~~
  - RAD = 10 ** 45
  - Visibility is internal
  - State mutability is constant
- Math unit constants used match their defined values
  - ~~HUNDRED = 10 ** 2~~
  - ~~THOUSAND = 10 ** 3~~
  - MILLION = 10 ** 6
  - BILLION = 10 ** 9
  - Visibility is internal
  - State mutability is constant
  - (Non-critical) Ensure they match with config
Address Declaration
- ~~Address Constants~~
  - ~~Address is not in the ChainLog~~
  - ~~Variable name matches corresponding entry in an addresses.sol file~~
  - ~~Address value matches corresponding entry in an addresses.sol file~~
  - ~~Visibility is internal~~
  - ~~State mutability is constant~~
- Address Immutables
  - Use the DssExecLib Core Address Helpers instead of getChangelogAddress() whenever possible (e.g. DssExecLib.vat())
  - Follow pattern address internal immutable KEY_NAME = DssExecLib.getChangelogAddress(KEY_NAME)
  - Variable name matches ChainLog key name
    - Exceptions must follow archive patterns (e.g. MKR for MCD_GOV)
  - Instantiate as address type
    - Exceptions must follow archive patterns (e.g. GemLike for MKR)
  - Visibility is internal
  - State mutability is immutable
String Constants
- IPFS hashes or DAO resolutions
  - IPFS hashes and DAO resolutions match the exec doc
  - The variable is named dao_resolutions
  - ~~if multiple dao resolutions are present~~
    - ~~they are located in the same string constant and are comma separated~~
    - ~~The comment above the the variable states: Comma-separated list of DAO resolutions IPFS hashes~~
- Must be TOP LEVEL (or ds pause will reject)
- Name of the variable matches purpose per EXEC DOC
- Visibility is public
- State mutability MUST BE constant
~~Deployed Contracts (not yet on chainlog or new to chainlog)~~
- ~~Verified on etherscan~~
- ~~Optimizations match Repo~~
- ~~GNU AGPLv3 license~~
- ~~Constructor args ok (e.g. vat, dai, dog, ...)~~
  - ~~Match ChainLog~~
- ~~Wards ok (pause proxy relied, deployer denied)~~
  - ~~MCD_ESM is already relied / being relied in this spell (as approved by GovAlpha) in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy.~~
- ~~Matches corresponding github source code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol)~~
- ~~Ensure deployer address is included into addresses_deployers.sol (to keep up to date)~~
[.] Core System Parameter Changes
- Stability Fee jug.ilk.duty (setIlkStabilityFee)
  - Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%.
- ~~Dai Savings Rate pot.dsr (setDSR)~~
  - ~~Double check that PCT_RATE is correct~~
    - ~~Check manually via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)~~
    - ~~Compare against IPFS~~
- ~~spotter.ilk.mat (liquidationRatio)~~
- ~~dog.ilk.hole (setIlkMaxLiquidationAmount)~~
- ~~vat.ilk.dust(setIlkMinVaultAmount)~~
- ~~dog.ilk.chop (liquidationPenalty)~~
- ~~clip.buf (startingPriceFactor)~~
- ~~clipperMom.clip.tolerance (setLiquidationBreakerPriceTolerance)~~
- ~~clip.tail (auctionDuration)~~
- ~~clip.cusp (permittedDrop)~~
- ~~clip.chip (kprPctReward)~~
- ~~clip.tip(kprFlatReward)~~
- ~~calc.tau (setLinearDecrease)~~
- ~~setStairstepExponentialDecrease~~
  - ~~calc.cut~~
  - ~~calc.step~~
Debt Ceiling Changes
- ~~vat.ilk.line changes (per ilk)~~
  - ~~Collateral type (ilk) is not RWAXXX (For RWA refer to the designated section of the checklist)~~
  - ~~setIlkDebtCeiling or increaseIlkDebtCeiling or decreaseIlkDebtCeiling~~
    - ~~ilk~~
    - ~~amount~~
    - ~~global~~
- ~~vat.Line changes (Global Line)~~
  - ~~setGlobalDebtCeiling or increaseGlobalDebtCeiling or decreaseGlobalDebtCeiling~~
    - ~~amount~~
- Autoline Changes
  - setIlkAutoLineDebtCeiling
    - ilk
    - line
  - setIlkAutoLineParameters
    - ilk
    - line
    - gap
    - ttl
~~Onboarding (insert relevant checklists inline here)~~
- ~~Collateral Onboarding~~
- ~~RWA Onboarding~~
- ~~Teleport Onboarding~~
Offboarding (Lerp mat)
- 1st Stage Spell Actions
  - Remove Ilk from Autoline
  - Set Ilks Debt Ceilings to 0
  - Cache Ilks line to Reduce in the Global Debt Ceiling
  - Decrease Global Debt Ceiling by Total Amount of Offboarded Ilks line Cached
- ~~2nd Stage Spell Actions~~
  - ~~Set Ilk Liquidation Penalty chop to 0~~
  - ~~Set Keeper Incentive Flat Rate tip to 0~~
  - ~~Check IF chip is required to be adjusted as well~~
  - ~~Use DssExecLib.linearInterpolation~~
    - ~~name Format matches "XXX-A Offboarding"~~
    - ~~target matches spotter~~
    - ~~ilk Format matches "XXX-A"~~
    - ~~what matches mat~~
    - ~~startTime matches block.timestamp~~
    - ~~start matches Var CURRENT_XXX_A_MAT~~
    - ~~end matches Var TARGET_XXX_A_MAT (Match Exec Sheet & Risk Computations)~~
      - ~~Check IF Target mat Covers All Remaining Vaults CR times Risk Multiplier Factor~~
    - ~~duration matches Exec Sheet~~
RWA Updates
- ~~doc (Using the _updateDoc helper or otherwise)~~
  - ~~init the RwaLiquidationOracle to reset the doc~~
  - ~~Sanity Check pip must be set (not the zero address)~~
  - ~~ilk follows format "RWAXXX-A"~~
  - ~~val price ignored (0) if init has already been called~~
  - ~~doc new legal document (IPFS HASH) matches Doc (or Forum Post)~~
  - ~~tau parameter used is the old tau value~~
- Autoline (line) + Liquidation Oracle Price Bump (val)
  - Enable Autoline
    - ilk follows format "RWAXXX-A"
    - line (max debt ceiling)
    - gap
    - ttl
  - bump RwaLiquidationOracle with new computed increased price (val)
    - ensure val is set accordingly with autoline max debt ceiling (line)
    - val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio (see below)
      - New val is calculated with line * [(1 + duty) ** years] * mat - rounded up - and makes sense in context of the rate mechanism. Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding.
      - Comment explaining val formula (Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio) is present
      - Accompanying comment above bump line in format // XXM * 1.XX^X * X.XX as a WAD corresponding to the val calculation formula (e.g. // 15M * 1.03^2 * 1.00 as a WAD) is present along with the calculation formula on the line above
        
        SF is zero so should probably replace the formula with the comment like this ❌
      - IF combining val of multiple RWA ilks being combined, val calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal.
  - Poke spotter to pull in the new price
- ~~Debt Ceiling (line) + Liquidation Oracle Price Bump (val)~~
  - ~~Increase Ilk Debt Ceiling (set DC + increase Global DC)~~
  - ~~bump RwaLiquidationOracle with new computed increased price (val)~~
    - ~~val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio (see below)~~
      - New val is calculated with line * [(1 + duty) ** years] * mat - rounded up - and makes sense in context of the rate mechanism. Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding.
      - ~~Comment explaining val formula (Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio) is present~~
      - Accompanying comment above bump line in format // XXM * 1.XX^X * X.XX as a WAD corresponding to the val calculation formula (e.g. // 15M * 1.03^2 * 1.00 as a WAD) is present along with the calculation formula on the line above
      - IF combining val of multiple RWA ilks being combined, val calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal.
  - ~~Poke spotter to pull in the new price~~
Payments
- Payments are not crafted or reviewed on Goerli (comments may be present)
~~SubDAO Content~~
- ~~SubDAO SubProxy spell execution~~
  - ~~SubDAO spell address matches Exec Sheet (comment or otherwise)~~
  - ~~IF SubDAO spell deployer is a smart contract (e.g. multisig or factory)~~
    - ~~Ensure the deployer address is in addresses_deployers.sol as an entry~~
  - ~~Executed using ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));~~
  - ~~Execution is NOT delegate call~~
  - ~~Reviewer Note: Gas cost may be very high as SubDAO spells execute within the main cast execution. (Also note that low level call gas estimation is not done by our scripts)~~
- ~~Maker Core (main spell) SubDAO actions (i.e. operate in Pause Proxy DelegateCall context)~~
  - ~~No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)~~
  - ~~SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)~~
  - ~~SubDAO contracts and all libraries / dependencies are verified (Blocking if not true)~~
  - ~~Upgradable SubDAO contracts~~
    - ~~Any upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)~~
      - ~~Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)~~
  - All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Sheet and are correct. SubDAO addresses being authed or given any permissions and addresses being called must be confirmed by the SubDAO spell team.
  - ~~SubDAO actions match Exec Sheet (only where inline with main spell code) and do not affect core contracts~~
  - ~~Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the Exec Sheet and match the code~~
  - ~~External calls for SubDAO content are NOT delegate call~~
  - ~~Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)~~
~~External Contracts Calls (Not SubDAOs, e.g. Starknet)~~
- ~~Target Contract don't block spell execution~~
- ~~External call is NOT delegate call~~
- ~~Target Contract doesn't have permissions on the Vat~~
- ~~Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)~~
- ~~Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code~~
- ~~MCD Pause Proxy doesn't give any approvals~~
- ~~All possible actions of the Target Contract are documented~~
- ~~Target contract is not upgradable~~
- ~~Target Contract is included in the ChainLog~~
- ~~Test Coverage is comprehensive~~
~~ChainLog~~
- ~~Increment ChainLog version based on update type~~
  - ~~Major -> New Vat (++.0.0)~~
  - ~~Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)~~
  - ~~Patch -> Collateral addition or addition/modification (0.0.++)~~
addresses_goerli.sol matches spell code
Ensure every spell variable is declared as public/internal
Ensure every spell variable is used in the spell (no unused variables)
- RAD not used ❌
Spell actions match the corresponding Exec Sheet

Tests

Ensure each spell action has sufficient test coverage
- Non-Scope defined parameter changes
- SF changes
- RETH-A offboarding stage 1
- Adjustment of RWA007
- Adjustment of RWA015
Ensure every test function is declared as public if enabled or private if disabled
Ensure that the DssExecLib.address file is not being modified by the spell PR
Check all CI tests are passing as at the latest commit
499b7b5

Check all tests are passing locally using make test

Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x122F6c0Dcd898b4a07310E92c3eAE5D7Ce0c8bb6
[⠘] Compiling...
[⠒] Compiling 6 files with 0.8.16
[⠒] Solc 0.8.16 finished in 1.73s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1164166)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 280.62s

Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 52179062)
[PASS] testAuthInSources() (gas: 8190427)
[PASS] testBytecodeMatches() (gas: 2284491)
[PASS] testCastCost() (gas: 1005060)
[PASS] testChainlogValues() (gas: 9381042)
[PASS] testChainlogVersionBump() (gas: 4432173)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2270357)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 38118126)
[PASS] testNextCastTime() (gas: 364790)
[PASS] testOnTime() (gas: 1000699)
[PASS] testPSMs() (gas: 2287352)
[PASS] testUseEta() (gas: 363519)
[PASS] test_RWA007_Update() (gas: 1225671)
[PASS] test_RWA015_Update() (gas: 1193674)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 854.06s

Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)

src/DssSpell.sol

amusingaxl · 2023-10-10T13:13:17Z

src/DssSpell.sol

+        (,,,uint256 line,) = VatLike(MCD_VAT).ilks("RETH-A");
+        DssExecLib.removeIlkFromAutoLine("RETH-A");
+        DssExecLib.setValue(MCD_VAT, "RETH-A", "line", 0);
+        // NOTE: decreasing globalline suniglow level API because of precision loss when using DssExec


Suggested change

// NOTE: decreasing globalline suniglow level API because of precision loss when using DssExec

// NOTE: decreasing global line using the low level API because of precision loss when using DssExecLib

amusingaxl

❌ Test coverage for RWA liquidation is not good.
It is trying to draw 0 after spell being executed.

src/DssSpell.t.sol

amusingaxl

Good to deploy

Goerli Executive Spell Review Checklist

Goerli 2023-10-11

Spell Actions (Per Exec Sheet):

Development Stage

Office Hours
- OFF (On Goerli the deployed spell is cast with a pause delay of 60 sec.)
30 days spell expiry in constructor (block.timestamp + 30 days)
No Exec Doc Hash on Goerli
Spell Description
- Ensure description exactly matches 'Goerli Spell'
Local Environment Actions
- Update Foundry by running foundryup
- Reinstall libraries by running rm -r lib && git submodule update --init --recursive
```
Insert checked out submodule paths here
```
- Library Checks
  - dss-exec-lib
    - If submodule upgrades are present make sure dss-exec-lib is synced as well
    - (Non-critical) Submodule hash matches the latest release version (NOTE: dss-exec-lib as installed locally will use GitHub code more recent than the 0.0.9 release until the 0.0.10 release)
  - dss-test
    - dss-interfaces
      - (Non-critical) Submodule hash matches version used by dss-test
      - (Non-critical) Submodule hash matches version used by dss-exec-lib
    - forge-std
      - (Non-critical) Submodule hash matches version used by dss-test
      - (Non-critical) Submodule hash matches version used by dss-exec-lib
Rate constants used are correct
- Manual check 1: Calculate rates using make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
- Manual check 2: Compare rates used against IPFS rate list
- Variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%, SIX_PCT_RATE for 6.00%)
- Visibility is internal
- State mutability is constant
Constants Match
- Precision unit constants used match their defined values
  - WAD = 10 ** 18
  - RAY = 10 ** 27
  - RAD = 10 ** 45
  - Visibility is internal
  - State mutability is constant
  - (Non-critical) Ensure they match with ds-math and the Numerical Ranges
- Math unit constants used match their defined values
  - HUNDRED = 10 ** 2
  - THOUSAND = 10 ** 3
  - MILLION = 10 ** 6
  - BILLION = 10 ** 9
  - Visibility is internal
  - State mutability is constant
  - (Non-critical) Ensure they match with config
Address Declaration
- Address Constants
  - Address is not in the ChainLog
  - Variable name matches corresponding entry in an addresses.sol file
  - Address value matches corresponding entry in an addresses.sol file
  - Visibility is internal
  - State mutability is constant
- Address Immutables
  - Use the DssExecLib Core Address Helpers instead of getChangelogAddress() whenever possible (e.g. DssExecLib.vat())
  - Follow pattern address internal immutable KEY_NAME = DssExecLib.getChangelogAddress(KEY_NAME)
  - Variable name matches ChainLog key name
    - Exceptions must follow archive patterns (e.g. MKR for MCD_GOV)
  - Instantiate as address type
    - Exceptions must follow archive patterns (e.g. GemLike for MKR)
  - Visibility is internal
  - State mutability is immutable
String Constants
- IPFS hashes or DAO resolutions
  - IPFS hashes and DAO resolutions match the exec doc
  - The variable is named dao_resolutions
  - if multiple dao resolutions are present
    - they are located in the same string constant and are comma separated
    - The comment above the the variable states: Comma-separated list of DAO resolutions IPFS hashes
- Must be TOP LEVEL (or ds pause will reject)
- Name of the variable matches purpose per EXEC DOC
- Visibility is public
- State mutability MUST BE constant
Deployed Contracts (not yet on chainlog or new to chainlog)
- Verified on etherscan
- Optimizations match Repo
- GNU AGPLv3 license
- Constructor args ok (e.g. vat, dai, dog, ...)
  - Match ChainLog
- Wards ok (pause proxy relied, deployer denied)
  - MCD_ESM is already relied / being relied in this spell (as approved by GovAlpha) in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy.
- Matches corresponding github source code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol)
- Ensure deployer address is included into addresses_deployers.sol (to keep up to date)
Core System Parameter Changes
- Stability Fee jug.ilk.duty (setIlkStabilityFee)
  - Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%.
- Dai Savings Rate pot.dsr (setDSR)
  - Double check that PCT_RATE is correct
    - Check manually via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    - Compare against IPFS
- spotter.ilk.mat (liquidationRatio)
- dog.ilk.hole (setIlkMaxLiquidationAmount)
- vat.ilk.dust(setIlkMinVaultAmount)
- dog.ilk.chop (liquidationPenalty)
- clip.buf (startingPriceFactor)
- clipperMom.clip.tolerance (setLiquidationBreakerPriceTolerance)
- clip.tail (auctionDuration)
- clip.cusp (permittedDrop)
- clip.chip (kprPctReward)
- clip.tip(kprFlatReward)
- calc.tau (setLinearDecrease)
- setStairstepExponentialDecrease
  - calc.cut
  - calc.step
Debt Ceiling Changes
- vat.ilk.line changes (per ilk)
  - Collateral type (ilk) is not RWAXXX (For RWA refer to the designated section of the checklist)
  - setIlkDebtCeiling or increaseIlkDebtCeiling or decreaseIlkDebtCeiling
    - ilk
    - amount
    - global
- vat.Line changes (Global Line)
  - setGlobalDebtCeiling or increaseGlobalDebtCeiling or decreaseGlobalDebtCeiling
    - amount
- Autoline Changes
  - setIlkAutoLineDebtCeiling
    - ilk
    - line
  - setIlkAutoLineParameters
    - ilk
    - line
    - gap
    - ttl
Onboarding (insert relevant checklists inline here)
- Collateral Onboarding
- RWA Onboarding
- Teleport Onboarding
Offboarding (Lerp mat)
- 1st Stage Spell Actions
  - Remove Ilk from Autoline
  - Set Ilks Debt Ceilings to 0
  - Cache Ilks line to Reduce in the Global Debt Ceiling
  - Decrease Global Debt Ceiling by Total Amount of Offboarded Ilks line Cached
- 2nd Stage Spell Actions
  - Set Ilk Liquidation Penalty chop to 0
  - Set Keeper Incentive Flat Rate tip to 0
  - Check IF chip is required to be adjusted as well
  - Use DssExecLib.linearInterpolation
    - name Format matches "XXX-A Offboarding"
    - target matches spotter
    - ilk Format matches "XXX-A"
    - what matches mat
    - startTime matches block.timestamp
    - start matches Var CURRENT_XXX_A_MAT
    - end matches Var TARGET_XXX_A_MAT (Match Exec Sheet & Risk Computations)
      - Check IF Target mat Covers All Remaining Vaults CR times Risk Multiplier Factor
    - duration matches Exec Sheet
RWA Updates
- doc (Using the _updateDoc helper or otherwise)
  - init the RwaLiquidationOracle to reset the doc
  - Sanity Check pip must be set (not the zero address)
  - ilk follows format "RWAXXX-A"
  - val price ignored (0) if init has already been called
  - doc new legal document (IPFS HASH) matches Doc (or Forum Post)
  - tau parameter used is the old tau value
- Autoline (line) + Liquidation Oracle Price Bump (val)
  - Enable Autoline
    - ilk follows format "RWAXXX-A"
    - line (max debt ceiling)
    - gap
    - ttl
  - bump RwaLiquidationOracle with new computed increased price (val)
    - ensure val is set accordingly with autoline max debt ceiling (line)
    - val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio (see below)
      - New val is calculated with line * [(1 + duty) ** years] * mat - rounded up - and makes sense in context of the rate mechanism. Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding.
      - Comment explaining val formula (Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio) is present
      - Accompanying comment above bump line in format // XXM * 1.XX^X * X.XX as a WAD corresponding to the val calculation formula (e.g. // 15M * 1.03^2 * 1.00 as a WAD) is present along with the calculation formula on the line above
      - IF combining val of multiple RWA ilks being combined, val calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal.
  - Poke spotter to pull in the new price
- Debt Ceiling (line) + Liquidation Oracle Price Bump (val)
  - Increase Ilk Debt Ceiling (set DC + increase Global DC)
  - bump RwaLiquidationOracle with new computed increased price (val)
    - val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio (see below)
      - New val is calculated with line * [(1 + duty) ** years] * mat - rounded up - and makes sense in context of the rate mechanism. Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding.
      - Comment explaining val formula (Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio) is present
      - Accompanying comment above bump line in format // XXM * 1.XX^X * X.XX as a WAD corresponding to the val calculation formula (e.g. // 15M * 1.03^2 * 1.00 as a WAD) is present along with the calculation formula on the line above
      - IF combining val of multiple RWA ilks being combined, val calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal.
  - Poke spotter to pull in the new price
Payments
- Payments are not crafted or reviewed on Goerli (comments may be present)
SubDAO Content
- SubDAO SubProxy spell execution
  - SubDAO spell address matches Exec Sheet (comment or otherwise)
  - IF SubDAO spell deployer is a smart contract (e.g. multisig or factory)
    - Ensure the deployer address is in addresses_deployers.sol as an entry
  - Executed using ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
  - Execution is NOT delegate call
  - Reviewer Note: Gas cost may be very high as SubDAO spells execute within the main cast execution. (Also note that low level call gas estimation is not done by our scripts)
- Maker Core (main spell) SubDAO actions (i.e. operate in Pause Proxy DelegateCall context)
  - No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
  - SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)
  - SubDAO contracts and all libraries / dependencies are verified (Blocking if not true)
  - Upgradable SubDAO contracts
    - Any upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)
      - Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)
  - All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Sheet and are correct. SubDAO addresses being authed or given any permissions and addresses being called must be confirmed by the SubDAO spell team.
  - SubDAO actions match Exec Sheet (only where inline with main spell code) and do not affect core contracts
  - Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the Exec Sheet and match the code
  - External calls for SubDAO content are NOT delegate call
  - Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)
External Contracts Calls (Not SubDAOs, e.g. Starknet)
- Target Contract don't block spell execution
- External call is NOT delegate call
- Target Contract doesn't have permissions on the Vat
- Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)
- Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code
- MCD Pause Proxy doesn't give any approvals
- All possible actions of the Target Contract are documented
- Target contract is not upgradable
- Target Contract is included in the ChainLog
- Test Coverage is comprehensive
ChainLog
- Increment ChainLog version based on update type
  - Major -> New Vat (++.0.0)
  - Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
  - Patch -> Collateral addition or addition/modification (0.0.++)
addresses_goerli.sol matches spell code
Ensure every spell variable is declared as public/internal
Ensure every spell variable is used in the spell (no unused variables)
Spell actions match the corresponding Exec Sheet
Tests
- Ensure each spell action has sufficient test coverage
  - Non-Scope Defined Parameter Changes - WBTC DC-IAM Changes
    ✅ testGeneral
  - Stability Fee Changes
    ✅ testGeneral
  - Initial RETH-A Offboarding
    ✅ testGeneral
  - Reconfiguring Andromeda RWA015-A
    ✅ testGeneral / :white_check_mark: test_RWA015_Update
  - Reconfiguring Clydesdale RWA007-A
    ✅ testGeneral / :white_check_mark: test_RWA0007_Update
  - ~~Set up Governance Facilitator Streams~~ ⚠️ Ignored on Goerli
  - USDP-PSM Facilitation Incentives ⚠️ No test coverage, not mandatory. Maybe consider adding it.
- Ensure every test function is declared as public if enabled or private if disabled
- Ensure that the DssExecLib.address file is not being modified by the spell PR
- Check all CI tests are passing as at the latest commit
  ✅ 5fbcea5
- Check all tests are passing locally using make test
  - Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1163896)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 33.12s

Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 52178792)
[PASS] testAuthInSources() (gas: 8190157)
[PASS] testBytecodeMatches() (gas: 2289317)
[PASS] testCastCost() (gas: 1004790)
[PASS] testChainlogValues() (gas: 9380772)
[PASS] testChainlogVersionBump() (gas: 4431903)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2275165)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 38122659)
[PASS] testNextCastTime() (gas: 364790)
[PASS] testOnTime() (gas: 1000429)
[PASS] testPSMs() (gas: 2287136)
[PASS] testUseEta() (gas: 363519)
[PASS] test_RWA007_Update() (gas: 1225706)
[PASS] test_RWA015_Update() (gas: 1193749)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 1091.67s
 
Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)

SidestreamSweatyPumpkin · 2023-10-11T07:49:51Z

Good to deploy

Comments from 2023-10-11 Goerli Spell #231 (review) addressed:
- ec69d3a
- ec69d3a
adjustments at 5fbcea5 OK
No other unrequested/extra changes introduced.

Local test rerun:

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x122F6c0Dcd898b4a07310E92c3eAE5D7Ce0c8bb6
[⠔] Compiling...
No files changed, compilation skipped

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1163551)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 261.73s

Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 52178447)
[PASS] testAuthInSources() (gas: 8189812)
[PASS] testBytecodeMatches() (gas: 2289317)
[PASS] testCastCost() (gas: 1004445)
[PASS] testChainlogValues() (gas: 9380427)
[PASS] testChainlogVersionBump() (gas: 4431558)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2275165)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 38122314)
[PASS] testNextCastTime() (gas: 364790)
[PASS] testOnTime() (gas: 1000084)
[PASS] testPSMs() (gas: 2286860)
[PASS] testUseEta() (gas: 363519)
[PASS] test_RWA007_Update() (gas: 1253158)
[PASS] test_RWA015_Update() (gas: 1255198)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 788.73s

Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)

SidestreamSweatyPumpkin · 2023-10-12T07:33:42Z

Good to cast

Deployed Stage

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x122F6c0Dcd898b4a07310E92c3eAE5D7Ce0c8bb6
[⠔] Compiling...
[⠊] Compiling 4 files with 0.8.16
[⠒] Solc 0.8.16 finished in 1.53s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1164126)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 256.92s

Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 52179022)
[PASS] testAuthInSources() (gas: 8190387)
[PASS] testBytecodeMatches() (gas: 2289317)
[PASS] testCastCost() (gas: 1005020)
[PASS] testChainlogValues() (gas: 9381002)
[PASS] testChainlogVersionBump() (gas: 4432133)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2275165)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 38124986)
[PASS] testNextCastTime() (gas: 364790)
[PASS] testOnTime() (gas: 1000659)
[PASS] testPSMs() (gas: 2287320)
[PASS] testUseEta() (gas: 363519)
[PASS] test_RWA007_Update() (gas: 1253043)
[PASS] test_RWA015_Update() (gas: 1255543)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 784.33s

Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)

amusingaxl · 2023-10-12T12:04:46Z

Good to cast.

Deployed Stage

Using DssExecLib at: 0x122F6c0Dcd898b4a07310E92c3eAE5D7Ce0c8bb6
[⠒] Compiling...
[⠢] Compiling 4 files with 0.8.16
[⠃] Solc 0.8.16 finished in 1.47s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1163896)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 32.86s

Running 17 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 2289317)
[PASS] testCastCost() (gas: 1004790)
[PASS] testChainlogValues() (gas: 9380772)
[PASS] testChainlogVersionBump() (gas: 4431903)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2275165)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 38124756)
[PASS] testNextCastTime() (gas: 364790)
[PASS] testOnTime() (gas: 1000429)
[PASS] testPSMs() (gas: 2287136)
[PASS] testUseEta() (gas: 363519)
[PASS] test_RWA007_Update() (gas: 1253043)
[PASS] test_RWA015_Update() (gas: 1254968)
Test result: ok. 17 passed; 0 failed; 0 skipped; finished in 358.20s

Ran 2 test suites: 19 tests passed, 0 failed, 0 skipped (19 total tests)

SidestreamSweatyPumpkin · 2023-10-12T12:18:24Z

Cast and Merge Stage

Spell is Cast
- Check Cast Trace (via EthTx)
  - Ensure no reverts are present that block execution
    - Inspect low level call reverts if expected
  - Ensure all actions are executed and no out-of-gas errors are present
Ensure that no commits or changes have occurred since the spell was deployed and archived
Approve spell PR for merge via 'Approve' review option

amusingaxl

Good to merge 🥇

Cast and Merge Stage

Spell is Cast
- Check Cast Trace (via EthTx)
  - Ensure no reverts are present that block execution
    - Inspect low level call reverts if expected
  - Ensure all actions are executed and no out-of-gas errors are present
Ensure that no commits or changes have occurred since the spell was deployed and archived
Approve spell PR for merge via 'Approve' review option

0xdecr1pto added 5 commits October 5, 2023 18:43

chore: cleanup spell

54badb0

feat: add spell actions

98860f8

feat: RETH-A offboarding: remove from IAM, set ilk DC to 0 (globa lin…

fd6dfcb

…e decrease)

feat: add DAO resolution

fec4e49

chore: fix rates

8e35e7f

0xdecr1pto marked this pull request as ready for review October 9, 2023 13:57

0xdecr1pto requested a review from amusingaxl October 9, 2023 13:57

amusingaxl suggested changes Oct 9, 2023

View reviewed changes

feat: bump oracle price for RWA007 & RWA015

7307054

0xdecr1pto requested review from amusingaxl and SidestreamSweatyPumpkin October 9, 2023 20:21

0xdecr1pto added 2 commits October 10, 2023 00:16

chore: use low level API for reducing global DC for RETH-A

6c323d9

chore: add missing method to Vat interface

499b7b5

SidestreamSweatyPumpkin suggested changes Oct 10, 2023

View reviewed changes

src/DssSpell.sol Outdated Show resolved Hide resolved

src/DssSpell.sol Outdated Show resolved Hide resolved

src/DssSpell.sol Outdated Show resolved Hide resolved

chore: fix spell review

0eddab1

SidestreamSweatyPumpkin reviewed Oct 10, 2023

View reviewed changes

src/DssSpell.sol Outdated Show resolved Hide resolved

chore: add EOF

ec69d3a

amusingaxl reviewed Oct 10, 2023

View reviewed changes

amusingaxl suggested changes Oct 10, 2023

View reviewed changes

src/DssSpell.t.sol Show resolved Hide resolved

src/DssSpell.t.sol Show resolved Hide resolved

src/DssSpell.t.sol Show resolved Hide resolved

src/DssSpell.t.sol Show resolved Hide resolved

chore: fix tests for RWA bump

5fbcea5

amusingaxl previously approved these changes Oct 10, 2023

View reviewed changes

0xdecr1pto added 2 commits October 11, 2023 20:39

chore: add deploy info

1b0a3cd

chore: archive

d931479

0xdecr1pto dismissed amusingaxl’s stale review via d931479 October 12, 2023 06:48

SidestreamSweatyPumpkin approved these changes Oct 12, 2023

View reviewed changes

amusingaxl approved these changes Oct 12, 2023

View reviewed changes

0xdecr1pto merged commit 4681055 into master Oct 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2023-10-11 Goerli Spell #231

2023-10-11 Goerli Spell #231

0xdecr1pto commented Oct 5, 2023

amusingaxl left a comment

amusingaxl Oct 9, 2023

amusingaxl Oct 9, 2023

SidestreamSweatyPumpkin left a comment •

edited

Loading

amusingaxl Oct 10, 2023

amusingaxl left a comment

amusingaxl left a comment •

edited

Loading

SidestreamSweatyPumpkin commented Oct 11, 2023

SidestreamSweatyPumpkin commented Oct 12, 2023

amusingaxl commented Oct 12, 2023 •

edited

Loading

SidestreamSweatyPumpkin commented Oct 12, 2023 •

edited

Loading

amusingaxl left a comment

	DssExecLib.decreaseIlkDebtCeiling("RETH-A", line / RAD, true);
	DssExecLib.decreaseIlkDebtCeiling("RETH-A", line / RAD, /* global = */ true);

	// NOTE: decreasing globalline suniglow level API because of precision loss when using DssExec
	// NOTE: decreasing global line using the low level API because of precision loss when using DssExecLib

2023-10-11 Goerli Spell #231

2023-10-11 Goerli Spell #231

Conversation

0xdecr1pto commented Oct 5, 2023

Description

Contribution Checklist

Checklist

amusingaxl left a comment

Choose a reason for hiding this comment

Goerli Executive Spell Review Checklist

Goerli 2023-10-11

Development Stage

amusingaxl Oct 9, 2023

Choose a reason for hiding this comment

amusingaxl Oct 9, 2023

Choose a reason for hiding this comment

SidestreamSweatyPumpkin left a comment • edited Loading

Choose a reason for hiding this comment

Goerli Executive Spell Review Checklist

Goerli 2023-10-11

Development Stage

amusingaxl Oct 10, 2023

Choose a reason for hiding this comment

amusingaxl left a comment

Choose a reason for hiding this comment

amusingaxl left a comment • edited Loading

Choose a reason for hiding this comment

Goerli Executive Spell Review Checklist

Goerli 2023-10-11

Development Stage

SidestreamSweatyPumpkin commented Oct 11, 2023

Good to deploy

SidestreamSweatyPumpkin commented Oct 12, 2023

Deployed Stage

amusingaxl commented Oct 12, 2023 • edited Loading

Deployed Stage

SidestreamSweatyPumpkin commented Oct 12, 2023 • edited Loading

Cast and Merge Stage

amusingaxl left a comment

Choose a reason for hiding this comment

Cast and Merge Stage

SidestreamSweatyPumpkin left a comment •

edited

Loading

amusingaxl left a comment •

edited

Loading

amusingaxl commented Oct 12, 2023 •

edited

Loading

SidestreamSweatyPumpkin commented Oct 12, 2023 •

edited

Loading