Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Infoless deploy test timestamp test #172

Open
wants to merge 1 commit into
base: infoless_deploy_test
Choose a base branch
from

Conversation

brianmcmichael
Copy link
Contributor

Fixes issue described at #166 (review) without need for timestamp.

@brianmcmichael brianmcmichael changed the base branch from master to infoless_deploy_test February 24, 2023 16:32
@brianmcmichael
Copy link
Contributor Author

This loosens up the test a little bit by not requiring that we're on the exact block a spell has been deployed on, but that it will still expire within the expiration threshold. Since this is the only test that needed the exact timestamp I think it still provides sufficient assurance that the spell expiry is ok.

Copy link
Contributor

@iamchrissmith iamchrissmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me since it still proves we didn't create a long lived spell, but it does take away the protection of a short lived spell. I don't think there is a risk there, so just noting it

Copy link
Collaborator

@The-Arbiter The-Arbiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is OK

@naszam
Copy link
Contributor

naszam commented Apr 11, 2023

@brianmcmichael I think we can close this PR as timestamp will remain for now and consumed by the spell automation scripts and integration tests

@DaiFoundation-DevOps
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants