Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Sync spells-goerli with spells-mainnet #133

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

The-Arbiter
Copy link
Collaborator

@The-Arbiter The-Arbiter commented Nov 7, 2022

During PE-1098, Julien made some changes in config.sol for the goerli spell which I did not replicate in the mainnet spell. This PR will fix these discrepancies as well as other issues.

This PR brings the diffchecker diffs in config.sol down from 150+ to 10.

Changes to config.sol:

  • Comments around the difference in pause_delay value for spell system values
  • Changing mainnet collateral values to match Julien's basis points style expression (i.e. 40_00 instead of 4000) and removal of the seconds keyword
  • Changing clip_tip for TUSD-A to 0 on Goerli (currently 500).
    Note that the tip value on Goerli is actually 500 whereas on mainnet it is 0, so this will cause failure of this test for the spell immediately after this PR is merged on Goerli.
  • Changing individually commented lines (//) to block comments (/* */) to allow for use of DiffChecker when maintaining these files.
  • Addition of CRVV1ETHSTETH-A (commented out) to Goerli's config.sol
  • Addition of INST-WETH-A and INST-WBTC-A (both commented out) to Mainnet's config.sol

@brianmcmichael brianmcmichael changed the base branch from master to PE-1124-2022-12-09 December 2, 2022 17:06
Base automatically changed from PE-1124-2022-12-09 to master December 8, 2022 14:27
@DaiFoundation-DevOps
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ The-Arbiter
❌ brianmcmichael
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants