Fix binary search (#167)

makerdao · Feb 13, 2023 · 2d96dfe · 2d96dfe
1 parent 82d733c
commit 2d96dfe
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/DssSpell.t.base.sol b/src/DssSpell.t.base.sol
@@ -296,17 +296,17 @@ contract DssSpellTestBase is Config, DssTest {
         uint256 high = block.number;
         uint256 mid;
 
-        while (low != high) {
-            mid = (low + high) / 2;
+        while (low < high) {
+            mid = (low & high) + (low ^ high) / 2; // rounds down
             vm.rollFork(mid);
             if (_isContractDeployed(_spell)) {
-                high = mid - 1;
+                high = mid;
             } else {
                 low = mid + 1;
             }
         }
 
-        vm.rollFork(low + 1);
+        vm.rollFork(low);
     }
 
     function _isContractDeployed(address _spell) internal view returns (bool) {