Skip to content

Commit

Permalink
more specific requirement about logs
Browse files Browse the repository at this point in the history
  • Loading branch information
SidestreamColdMelon committed Nov 21, 2024
1 parent e400669 commit acdeee3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions spell/spell-crafter-mainnet-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] Insert the release URL here:
* [ ] Install the specified version via `foundryup --version git_tag_name`
```
Document the relevant installation logs below
Document the installation logs containing installed versions below:
```
* Create new branch
* [ ] Pull `master` branch of the `spells-mainnet` repo locally
Expand Down Expand Up @@ -217,7 +217,7 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] Commit & push changes for review
* [ ] Wait for CI to PASS
* [ ] Post a comment inside the PR containing:
* Relevant Foundry installation logs (from above or via `foundryup --version`)
* Foundry installation logs containing installed versions (from above)
* A link to the deployed spell
* A link to the created Tenderly Testnet
* [ ] Notify the reviewers (e.g. "the spell was deployed")
Expand Down
2 changes: 1 addition & 1 deletion spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* [ ] Insert the release URL here:
* [ ] Install the specified version via `foundryup --version git_tag_name`
```
Document the relevant installation logs below
Document the installation logs containing installed versions below:
```
* Preparation
* [ ] Exec Sheet for the specified date is found in the ["Executive Vote Implementation Process" google sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw)
Expand Down

0 comments on commit acdeee3

Please sign in to comment.