Skip to content

Commit

Permalink
chore: use same check for both checklist
Browse files Browse the repository at this point in the history
  • Loading branch information
SidestreamStrongStrawberry committed Aug 28, 2024
1 parent ee6bcae commit 6b87f04
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spell/spell-crafter-mainnet-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] Ensure that executive vote file name and date is correct
* [ ] [community](https://github.com/makerdao/community) repo commit hash corresponds to latest change
* [ ] Raw GitHub URL is correct
* [ ] Raw GitHub URL contains commit hash that introduced last change to the Exec Doc, NOT merge commit (Note: correct commit hash can be found using `git log --pretty=oneline -1 -- "$LOCAL_PATH_TO_EXEC_DOC"` command executed inside [`community`](https://github.com/makerdao/community) repo)
* [ ] Ensure the URL uses commit hash that introduced last change to the Exec Doc, NOT merge commit (Note: correct commit hash can be found using `git log --pretty=oneline -1 -- "$LOCAL_PATH_TO_EXEC_DOC"` command executed inside [`makerdao/community` GitHub repo](https://github.com/makerdao/community))
* [ ] Exec hash is correct (use `cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"` where `wget` doesn't work)
* [ ] Ensure `description` date in `DssSpell.sol` matches target date inside Exec Doc
* [ ] Make sure all review comments are either addressed or explicitly answered
Expand Down

0 comments on commit 6b87f04

Please sign in to comment.