This repository has been archived by the owner on May 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this release, the
statediff.watchedaddresses
flag will make sure that the statediff service only processes statediffs for given contract addresses. However, there is currently no filter to make sure that the statediff Payload is not empty before sending it over the subscription. The resulting behavior is that for all blocks that don't have a state diff for the given watched contract address, we end up sending a payload with an "empty" StateDiffRlp:and see a lot of
sending state diff payload to subscription...
logs, which is misleading.This issue has been fixed in the updated approach to statediffing: #5. Not sure if it makes sense to put in the time to fix the issue here in this statediffing approach as well or just wait until we start using the updated approach. 🤔