Hub.exec new structure (paying fees always) + removal of Hub.reap + Better pool shares on GS + Certora specs for Hub #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmooney-20220805: Fixes for CS 5.4 Inconsistencies * bound bar in AAVE plan to MAX_BORROW_RATE * Revert "bound bar in AAVE plan to MAX_BORROW_RATE" This reverts commit e2bf302.
* Add Certora * Add DISPATCHER(true) * Add checks * Fix * Minor changes * less restrictive spec * Use real Vat, DaiJoin and Dai code with solc 0.5.12 * Use D3MTestPool and D3MTestPlan * More checks and CI setup * Move certora.yml to correct place * Fix some asserts * Add exec_exec rule and some minor changes in exec_normal * More checks * multi assert flag via conditional * Improve checks and add comments * Use staging and old certora-cli version until production gets fixed * More checks * Add exec_ilk_culled * check dai in vow for normal path * Add exec_vat_caged * Add cage and cull * Add uncull * Add exit * Add exit_revert * Add cage_revert * Remove unnecessary stuff of cage_revert * Add cull_revert * Add uncull_revert + some variables renaming * Add rely, rely_revert, deny and deny_revert * Add file_ilk_uint256 and file_ilk_uint256_revert * Add file_ilk_address and file_ilk_address_revert * Add ilk_getters * Add exec_vat_caged_revert + minor changes * Add exec_ilk_culled_revert and minor chanegs to exec_vat_caged_revert * Use main staging + split CI runs in several * Use matrix for running all the rules in CI * Fix CI config file * Certora CI only on pushes (for now) * Add to ignore * Add timeout flag * Add exec_normal_revert (without checking if all the revert cases are covered) * Stick to specific certora-cli-alpha-master version * Verify inkAfter can't be higher than max_int256 * Add missing end lines
* More precise account for pools shares after shutdown + force unwinding if assets < ink * No more dapp * Minor changes * Rename test * Add exit tests * Fix exit and exit_revert specs * Fix exec_normal_revert expect with the new changes * Improve exit tests * Improving exec_normal spec * Fix comment * Enforce solc 0.8.14 in make test and use it for CI * Fix test rounding error * Remove unnecessary tests * 1e18 to wad and aave rounding (#88) * switch compound tests from 1e18 to WAD * fix aave test rounding issues * gonza fixing my assertEq dyslexia Co-authored-by: Gonzalo Balabasquer <[email protected]> Co-authored-by: Gonzalo Balabasquer <[email protected]> Co-authored-by: Chris Smith <[email protected]>
gbalabasquer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating the PR to this time use the classic commit and merge as the rebase one did change the commits hashes.