-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paging #29
base: main
Are you sure you want to change the base?
Paging #29
Conversation
I'm glad I waited a bit longer to make a review, the docs look excellent! I'll try to get a review out today, maybe before our meeting, but no promises |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall quite thorough, as far as i can tell, just some minor formatting/linting things and i'll be happy.
thank you for your effort!
the branch is also out of date with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb documentation and commenting! I have but a few small suggestions – the tests run smoothly and qemu still runs well after these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything appears to be in order!
Requested minor (non functionality changes). No response since June. Approved by others.
Description
Provides a way to interact with page tables and directories.
Also identity maps the first 12MiB.
Note: does not do allocation or anything that requires it. Intended for separate PR
Issue #28
Type of change
Testing
Existing tests all pass.
In addition, tests were added to verify the identity paging is valid.
And for translation of virtual address to physical address.
And for swapping the active page directory.
Test Configuration:
Checklist: