forked from UBAutograding/devU-api
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category score #67
Open
jessehartloff
wants to merge
131
commits into
main
Choose a base branch
from
category-score
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Category score #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time I want to start up this project, I spend 30 or so minutes figuring out authorization. Instead, I figured it would be easier to put an example in the documentation to cut setup time and enable more commits in the future!
Postman is an invaluable resource for new developers on this api. Having a pre-configured json file for postman will allow developers to understand exactly what a request looks like, and how they can make that request. Another option would be to host that json config file somewhere in this repo, so that we can make updates as we develop new endpoints.
Why is this file in the repo???
Delete .DS_Store
* Added a menu for the schema members * Added comments for new members * I suggest we replace comments with types, since "foreign key" seems easier to follow
Updated Schema Documentation
Postman Setup Docs
Fetching and using the bearer token
Minor updates to the schema
This resolves all vulnerabilities reported by `npm audit`, including the breaking change to `passport` from `^0.4.1` to `^0.6.0`. All tests still pass with these updates. Fixes #15
[Dependencies] Update deps to resolve vulns
Bumps [passport-saml](https://github.com/node-saml/passport-saml) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/node-saml/passport-saml/releases) - [Changelog](https://github.com/node-saml/passport-saml/blob/master/CHANGELOG.md) - [Commits](node-saml/passport-saml@v3.2.1...v3.2.2) --- updated-dependencies: - dependency-name: passport-saml dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Pretty much just default Node.js config, just changed to only run on PRs (instead of pushes and PRs targetting "master")
package.json defines requirement node >= 16
No idea if this will Just Work (TM), but I guess we'll find out soon!
GH concats it all into one line so escaping the line breaks isnt needed
This uses incorporates mattallty/jest-github-action to add annotations in the test files on the failing tests, making it easier to identify the problems
Test and Format now rely on Build, reducing duplicate code (if this works the way I think it will)
Last commit: > Test and Format now rely on Build, reducing duplicate code > (if this works the way I think it will) It did not. They're still unique environments, so it still has to be set up for each action
This reverts the failing test intentionally added in ddc6ce6
I won't tell it to actually commit yet, first I'll review the output to make sure it isn't committing too much
- Added postman file config - Edited docs for postman file
# Conflicts: # README.md # package-lock.json # package.json
Category Score Router Complete (Awaiting Controller and Validator)
…-and-body-parser-and-express-6.11.0 build(deps): bump qs, body-parser and express
…press-4.17.3 build(deps): bump express from 4.17.1 to 4.17.3
…onwebtoken-9.0.0 build(deps): bump jsonwebtoken from 8.5.1 to 9.0.0
…on5-2.2.3 build(deps): bump json5 from 2.2.0 to 2.2.3
Category Score Serializer
[GitHub Actions] Fix formatter action
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jsonwebtoken](https://github.com/auth0/node-jsonwebtoken) from 8.5.1 to 9.0.0. - [Release notes](https://github.com/auth0/node-jsonwebtoken/releases) - [Changelog](https://github.com/auth0/node-jsonwebtoken/blob/master/CHANGELOG.md) - [Commits](auth0/node-jsonwebtoken@v8.5.1...v9.0.0) --- updated-dependencies: - dependency-name: jsonwebtoken dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6 to 0.7.10. - [Release notes](https://github.com/xmldom/xmldom/releases) - [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md) - [Commits](xmldom/xmldom@0.7.6...0.7.10) --- updated-dependencies: - dependency-name: "@xmldom/xmldom" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Updated documentation
Add categoryScore Model
Implement CategoryScore service #57
…onwebtoken-9.0.0 build(deps): bump jsonwebtoken from 8.5.1 to 9.0.0
…nimatch-3.1.2 build(deps): bump minimatch from 3.0.4 to 3.1.2
…ldom/xmldom-0.7.10 build(deps): bump @xmldom/xmldom from 0.7.6 to 0.7.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the Category Score entity to the API. Also merging several dependency and documentation updates.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.