Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission problem score - Serializer #24

Conversation

alans-42
Copy link
Collaborator

@alans-42 alans-42 commented Oct 13, 2022

Proposed changes


This pull request adds the serializer and test for the submission problem score. Closes #12

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (Refer to further comments)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged downstream

Further comments


@alans-42
Copy link
Collaborator Author

Made this a draft because I still need to test my tests when SubmissionProblemScore is fully implemented

@jessehartloff jessehartloff changed the title Submission problem score Submission problem score - Serializer Oct 19, 2022
@alans-42 alans-42 marked this pull request as ready for review October 19, 2022 22:04
@jessehartloff jessehartloff merged commit ce5bbb4 into makeopensource:submissionProblemScore Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants